[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: yi (and dyre)



Hi,

it seems that Masayuki (who initially packaged yi) is not replying, so
I’ll do that.

Am Montag, den 01.07.2013, 17:19 +0200 schrieb Louis Bettens:
> I'm fond of Haskell and I have used Debian since early childhood and I 
> wanted to play about with the packaging tools, so I took a look at your 
> darcs repo and I tried to make a package for yi 0.6.7.0 (the current 
> packaging is for yi 0.6.6.0). I changed the debian/control according to 
> the dependencies indicated by yi.cabal

The previous changelog entry is UNRELEASED, so you should add your
changes to that. See
http://wiki.debian.org/Haskell/CollabMaint/Processes for more details.

Also, changing debian/rules with every update is not good. Can you
change the configure call to make yi use /usr/share/yi instead
of /usr/share/yi-0.6.7.0?

Also, shouldn’t "Setup copy" install all these files? Why is that not
used here?

>  and found out that it used a 
> newer version of dyre (0.8.11 whereas darcs.debian.org/pkg-haskell 
> contained only 0.8.9) so I updated the packaging for dyre too.

Thanks. Are there no commas required in the Uploaders field? Also, you
added a spurious space in the Build-Depends – better keep your patches
clean of such things for easier review.

>  I also 
> found out that yi-contrib was not packaged at all so I worked on it too.

You did not use the latest template for debian/control from
http://anonscm.debian.org/darcs/pkg-haskell/tools/template-debian/; I
suggest you use that, e.g. to avoid the description redundancy.

There is no need to constrain the versions of the -prof packages, as
they are tight to the -dev packages anyways, so better remove that
redundancy.

No need for debian/patches if there are no patches.

No need for a build/yi target in debian/rules.

Your debian/watch file is wrong (you need to change the package name in
two locations).


> Everything was validated by lintian and pbuilder. I would like you to 
> take a look at the attached tarball and outputs of darcs diff and also 
> to answer two questions :
> - yi-contrib.cabal says that yi-contrib 0.6.7.0 depends on yi 0.6.7.0 
> exactly. Every other dependency I've seen requires a version higher or 
> lower than a certain one. In order that dpkg-checkbuilddeps not fail, I 
> had to put "yi-contrib (= 0.6.7.0-1.1)" as a build dependency which 
> seems too specific. Is there another solution ?

You should specify the (likely) range of Debian versions corresponding
to that upstream version, e.g.

libghc-yi-dev (>= 0.6.7.0), libghc-yi-dev (<< 0.6.7.0.0)

> - When using pbuilder, if a package depends on another one that isn't in 
> the aptitude sid repo because I built it, what should I do ? I used 
> pbuilder --execute --save-after-exec on a script that installed all the 
> dependencies of the package with aptitude (I had to find them by hand 
> with dpkg -f) and then installed the .deb file located in 
> /var/cache/pbuilder/result (bind-mounted). Is there a better way, at 
> least an aptitude or apt-get command installing a .deb file with its 
> dependencies ?

I use sbuild, not pbuilder, but the problems are similar. For a quick
solution, just enter you changeroot with a shell and build both packages
manually, installing the first before building the second. For a more
permanent solution, create a local repository (e.g. with
dpkg-scanpackages), bind-mount that into the chroot and install from
there. See
http://wiki.debian.org/PbuilderTricks#How_to_include_local_packages_in_the_build for an explanation. For a proper solution, wait for http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700522 to be fixed.



Is this a one-shot contribution or do you want to become the proper
maintainer of yi? In the latter case, I suggest you join the DHG so that
your uploads are not NMUs. Are you subscribed to debian-haskell@l.d.o?

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: