On Mon, Mar 19, 2012 at 10:02:57AM +0100, Joachim Breitner wrote: > Hi, > > Am Sonntag, den 18.03.2012, 12:47 +0100 schrieb Iustin Pop: > > On Sun, Mar 18, 2012 at 11:43:47AM +0000, Iustin Pop wrote: > > > Sun Mar 18 11:38:01 UTC 2012 Iustin Pop <iustin@debian.org> > > > * Initial Check-In > > > Ignore-this: 84893d5b7da4cd2aac0e3cd49742bb74 > > > > > > A ./changelog > > > A ./compat > > > A ./control > > > A ./copyright > > > A ./rules > > > A ./shelltest.md > > > A ./shelltestrunner.install > > > A ./shelltestrunner.manpages > > > A ./source/ > > > A ./source/format > > > A ./watch > > > > Hi all, > > > > Can someone check my packaging for shelltestrunner? It's my first > > haskell package, and while the Haskell/CollabMaint docs are nice, I > > would very much appreciate someone making sure I didn't do some basic > > mistakes. > > > > If things look OK, I'll switch changelog to unstable and send it towards > > the NEW queue :) > > Well, it is a binary, not a library, so somewhat different from most our > packages. Some comments: > > Remove this comment: > # Make sure all dependencies listed in the cabal file are represented here, > # including their version bounds. It is sufficient to add the bounds to the > # -dev package only. Thanks, will do. > > You chose the debian/*.install-way of installing the binary. Based on the hlint package, which I got from the mailing list archives as a binary example, I had not preference otherwise. > There is > another way which I find cleaner, and which you can see in the > threadscope package; this uses cabal copy and will also work with > possible data files (but does not work so well if it is a > executable/library-bundle). I've looked at threadscope, but it seems to me that the cabal copy is more fragile: you don't know/control what it will be installed. Hence, the fact that (in threadscope) you have to manually remove debian/…/usr/share/doc. Anyway, if that's more standard, I'll switch to that, no problem. By the way, speaking of threadscope: I've seen one issue (wrong Vcs-* URLs) and a small optimisation (replace in debian/rules threadscope with $(CABAL_PACKAGE)), and I've committed fixes for these; I hope this is OK by the etiquette of the group. > With more and more Haskell programs being packaged, we should really > move this functionality into hlibrary.mk, with some automatism such as > (for a Cabal package foo): > * If there is a binary bar, and a binary package bar, > install /usr/bin/bar in that package. > * Otherwise, if there is a binary package foo, > install /usr/bin/bar into foo. > * Install data files into foo, if it exists, otherwise into > libghc-foo-dev. > * And all that somehow configurable via variables, e.g. > PACKAGE_FOR_bar := foo-utils > PACKAGE_FOR_DATA := foo-common > > Any volunteers? Heh, not me, just starting on this :) thanks, iustin
Attachment:
signature.asc
Description: Digital signature