[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITP: haskell-dbus -- Haskell bindings for D-Bus API

Hi Rafael.

Excerpts from Rafael Cunha de Almeida's message of Qui Dez 30 20:32:03 -0200 2010:
> Marco Túlio Gontijo e Silva <marcot@debian.org> disse:
> > Is the package usable without libdbus headers?  You probably want to add
> > libdbus-1-dev as a dependency for libghc6-dbus-dev.  For instance,
> > libghc6-gtk-dev depends on libgtk2.0-dev.
> It seems to work fine. It is curious to me that libghc6-gtk-dev would
> depend on libgtk2.0-dev. Do you know why that happens? Being it a
> haskell library, why would C headers be needed for anything?

Well, it's not the headers that are required, but the symlinks for ld (check
Policy 8.4).  I installed your package without libdbus-1-dev and got the

$ cat teste.hs
import DBus.Connection

main :: IO ()
main = busGet Session >>= close
$ ghc --make teste
Linking teste ...
/usr/bin/ld: cannot find -ldbus-1
collect2: ld returned 1 exit status

> > Also, I don't see much point in libghc6-dbus-prof recommending dbus, maybe only
> > libghc6-dbus-dev recommending it is enough.  Is dbus useful for building packages
> > or for using the binaries produced?  Maybe it can be a Suggests.
> A binary produced with libghc6-dbus-dev is probably unusable without
> dbus installed.

Do you mean without dbus (the daemon and utilitaries) installed or libdbus-1-3
(the shared library)?  Sorry, I'm not familiar with dbus.  Notice that if you
include libdbus-1-dev in the dependencies of libghc6-dbus-dev, this will also
include libdbus-1-3, since libdbus-1-dev depends on libdbus-1-3.  If the only
reason you're Recommending dbus is because of the share library, you don't need
this recommendation at all.

> Policy 7.2 says "The Recommends field should list packages that would be
> found together with this in all but unusual installations". I consider an
> installation that's capable of compiling a program but not running it
> afterwards an unusual installation.


> Since prof already depends on dev, it shouldn't make a difference if it
> recommends the same packages or not, right?


> However, let's take  the
> scenario of someone who, for whatever reason, have libghc6-dbus-dev
> installed but not prof or dbus. Then, when that person is to install
> prof, shouldn't he be reminded that prof recommends dbus? What's the
> harm in having it stated both in prof and dev?

There's no harm, but I don't think Recommends are used to remember the user to
install a package at different times, but to declare a relationship between
packages.  I don't see a special relationship from libghc6-dbus-prof to dbus,
I only see it between libghc6-dbus-dev and dbus.

> > Have you sent the patch upstream?
> No. I was waiting to see if any of you would have comments on them.

I think it's ok.

> > And as Joachim said, don't forget to run lintian, maybe even with --pedantic,
> > ignoring no-upstream-changelog.
> I have included the close bug tag. If I use lintian on the .changes that
> pdebuild creates in the parent directory from where it was called, then
> it reports nothing. But it does report something if I run on
> /var/cache/pbuilder/result's .changes. The difference is that the former
> includes the .deb. Is that the best file to run lintian on or is there a
> even better target?

Yes, the .changes in the parent directory is for the construction of the source
package only.  The other one is where you're supposed to run it.

> Me included? :-P

No, thanks for that, corrected.


Attachment: signature.asc
Description: PGP signature

Reply to: