Hi,
Am Mittwoch, den 23.12.2009, 01:00 +0100 schrieb Giovanni Mascellani:
> Joachim Breitner ha scritto:
> > while there are git advocates in the group, and we don’t dictate an
> > option, I’d suggest Darcs. Primary reason: I prefer it (for DHG
> > purposes), and it’s integrated in
> > http://pkg-haskell.alioth.debian.org/cgi-bin/pet.cgi which is a great
> > plus when it comes to sponsoring uploads.
>
> Ok, I'll learn it!
I noticed you tagged haskell-sha for unstable, so I’m doing a little
review:
* Priority: is optional, should be extra (this is a very recent change
discussed on the mailing list). Fixing that myself.
* Having each (build-)dependency on a line of its own makes it easier
to read them, and especially to read darcs diffs.
* Depends: libghc6-sha-dev (= ${binary:Version}) should not be
necessary, as ${haskell:Depends} takes care of that.
* Since the .haddock files are shipped in the -dev package, the -doc
dependencies must go in Build-Depends, not Build-Depends-Indep.
Generally, you do not need Build-Depends-Indep for Haskell packages.
* Did you test building the package in pbuilder? It seems not, as you
don’t build-depend on hscolour, so such a build is likely to fail.
* There seems to be a consensus for libghc6-*-doc for the doc package
name for new packages.
* Your watch file does not follow the shape that most package are
using, it seems. But maybe we should switch to what I proposed in the
mail „Re: Hackage vs. uscan (debian/watch) in darcs.d.o repos“ from
23.11.2009. Marco, did you have a look at that watch line? Is it ok, can
it be improved or simplified? Do you feel like doing another round of
mass-package-updates? :-)
I’m untagging the package until you adressed these issues, ok?
Also, Giovanni, there is a bug with darcs on alioth and hanging
processes. Please run "ssh alioth killall -KILL darcs" after pushing
patches, to prevent them from taking 100% CPU and cause global warming.
Greetings,
Joachim
--
Joachim "nomeata" Breitner
Debian Developer
nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
Attachment:
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil