Bug#987332: aprx automatically starts up with really bad default config

[Apostolos Kefalas <sv1ljj@raag.org>]

Hello Hibby,

Please review the below patch


--- a/config.c
+++ b/config.c
@@ -340,6 +340,9 @@
 		config_STRUPPER(param1);
 		// Store these always, it helps with latter error diagnostics
 		mycall       = strdup(param1);
+		if (strcmp(mycall, "N0CALL-1") == 0) {
+			return 1;
+		}
 #ifndef DISABLE_IGATE
 		aprsis_login = mycall;
 #endif


thanks
Apostolos




On Wed, 2021-05-05 at 23:06 +0100, Hibby wrote:
> Hi all,
> 
> I had a quick look at the code - config.c carries a validate_callsign_input()
> function, which I think we could patch a check in to cause the program to exit
> with an incorrect callsign for APRS-IS error.
> 
> Alternatively, it’s checking for a 6 character callsign, so we could make
> N0CALL-1  longer by a character or two in the config to force an error.
> 
> Do either of these seem like a reasonable way to force an error, or will this
> just end up with the failed upgrades we want to avoid?
> 
> —
> Hibby
> MM0RFN