[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Permission for 'dev/pmu'



On Tue, Jan 11, 2005 at 01:21:02PM +0100, Frederic Peters wrote:
> Martin-Éric Racine wrote:
> 
> > > Sjoerd proposed to replace acme_error by g_warning; it *is* trivial.
> > > Patch attached.
> > 
> > This patch fails as-is, because another patch removes that code fragment.
>  
> Yes, it was done a bit too fast, Sjoerd pointed this in a later mail
> and announced he has a correct patch in his local package.

So let's solve this. So, as i understand the current prefered fix is : 

  1) if there is no /proc/device-tree/aliases/via-pmu -> we issue a warning.

  2) if the /dev/pmu device is not existent and/or not writteable
     -> we issue a warning, and don't use the feature

  3) if the /dev/pmu is existent and writteable -> we use the feature

By default, the /dev/pmu is not writteable, so the feature is disabled, so we
need to add a line in Debian.Readme explaining this, and also the relative
unsecurity of this approach.

Does this solve the issue ? Does this make the feature usable to everyone
satisfaction ? I would say yes, so let's do it and not speak about this until
the gnome 2.10 or whatever release which use the advanced hal thingy.

Friendly,

Sven Luther



Reply to: