On Sat, Oct 21, 2023 at 01:54:45PM +0300, Taavi Väänänen wrote:
> On 10/18/23 23:01, Nilesh Patra wrote:
> > * Will the "soju" user and corresponding group be automatically deleted
> > once the package is removed?
> > I don't really know if sysuser handles that by default.
>
> Good point, I don't see an easy way to do that with sysusers. I moved the
> package to use adduser.
I have pushed a small change with reasoning to properly fix those. However, I have two
questions to ask:
* Why is the groupname of soju user names "ssl-cert" and not soju itself?
* Do we expect a "ssl-group" to be commonly present in linux systems? If
not (it isn't on mine), should it not be:
- Created in d/postinst? -- There is no groupadd or --ingroup with
adduser
- Removed in d/postrm? -- no delgroup
> > * Can you write a simple autopkgtest for testing soju binary?
> > Checking something like user is initialized or not etc. You could
> > take a look at caddy and orthanc package as examples.
>
> Sure. I added two tests, one to run the upstream testsuite with PostgreSQL
> database support available (something that we can't do build time), and an
> another to test that the service starts, can be interacted with the sojuctl
> tool and that an IRC connection can authenticate fine.
This looks great! Thanks!
Best,
Nilesh
Attachment:
signature.asc
Description: PGP signature