On 10/18/23 23:01, Nilesh Patra wrote:
A couple of comments/questions not an exhaustive review before I go AFK (to sleep, it is 1:30AM here)
Thank you!
* Shouldn't "/var/lib/soju" be removed in a postrm script?
Yes, done.
* Will the "soju" user and corresponding group be automatically deleted once the package is removed? I don't really know if sysuser handles that by default.
Good point, I don't see an easy way to do that with sysusers. I moved the package to use adduser.
* Can you write a simple autopkgtest for testing soju binary? Checking something like user is initialized or not etc. You could take a look at caddy and orthanc package as examples.
Sure. I added two tests, one to run the upstream testsuite with PostgreSQL database support available (something that we can't do build time), and an another to test that the service starts, can be interacted with the sojuctl tool and that an IRC connection can authenticate fine.
Taavi
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature