Hi Sebastian, On Thu, Sep 21, 2023 at 12:20:50 +0100, Sebastian Crane wrote: > - You'll need to push an 'upstream' branch as well as the 'debian/sid' > branch to Salsa when you get access. No problem -- I wasn't quite sure of the order in which to generate ITP and upload to Salsa, etc, so ended up putting my work on GitHub for the time being. I'll ensure the upstream branch is also pushed to Salsa. > - The description shouldn't be the whole README; you can just have 'Go > library for building L2TP applications on Linux systems' on the first > line and the list of features as the extended description. If you > think it's important that users have access to the documentation, you > can put something in /usr/share/doc (it looks like you've already got > manpages there already). It is generally unusual to have extra > documentation for Go libraries in Debian, since they aren't really > intended for use outside of making other Debian software work. I understand. I'll trim the description down. > - If you abridge the description, you can also delete > go-l2tp.lintian-overrides. Ack, will do. > - Why do you have an 'override_dh_auto_install' rule in the Makefile? I > don't know if something has changed recently in dh-make-golang, but it > wasn't there last time I used it. Hmm. I'll double check that. I don't *think* I did anything extra here, so I suspect that dh-make-golang produced this output but I will investigate further. > All in all, I think it looks pretty close to upload :) Ace -- many thanks for the review :-) Tom
Attachment:
signature.asc
Description: PGP signature