Am 23.06.21 um 00:43 schrieb Nilesh Patra:
On 6/23/21 3:58 AM, Peymaneh Nejad wrote:Yet another package that github.com/smallstep/zcrypto resp. caddy depends on: https://salsa.debian.org/go-team/packages/golang-github-weppos-publicsuffix-goIn d/copyright: 1. registry <info@jprs.jp> registry <Michael.Daly@nominet.org.uk> Looks sort of weird. Are you sure that the name "registry" is correct?
I understand it is how these entries were attributed by the contributors themselves[1] in the original source but I added the real world names to the respective mail adresses :)
2. In "fixtures/tests.txt" file I think it is sensible to assume that the authors of this file are the same as upstream ones. So you might want to remove "Copyright: n/a" In cmd/: Do you think those binaries will be needed? These don't look particularly important to me though
Thats right, fixed that.
PS: I'll take a look at your changes tomorrow morning, it's late night and I need to go. Thanks for your work!
Good night [1] https://github.com/publicsuffix/list/wiki/Guidelines#private-domains [2] https://publicsuffix.org/list/public_suffix_list.dat
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature