Hi Alex, On 7/4/21 2:32 PM, Flu0r1ne wrote: > Hi Nilesh, > > I wrote a trivial patch that makes it 1.13 compatible. Very cool! > >>> It also complains that no manual pages are included. Although, the >>> project hasn't >>> >>> produced any to my knowledge. >> If nebula supports -h/--help option, you might want to create maintainer manual pacges via help2man and forward that upstream. >> This handy script might help you[3] > > I did this; it's now on salsa. Looks good, however to make it easy for future ref, I'd suggest putting in the createmanpages script in the debian/ dir so when future versions are released, manpages can be updated with a simple `$ /bin/sh debian/createmanpages` >>> >>> probably want to clone them again. >> I will grant you push access to the team after a few more reviews so they are at a central place > > Sounds good. I have added you to the team. But since you're not a DD, I'm not supposed to grant you access above developer. We have dh-make-golang[1] which has a `create-salsa-project` subcommand. It can create projects or you without escalated permissions. Please do so and push your work to the team. > > Let me know if we need to make any other changes. I did a quick review, and I think the debian/ dir should be licensed under the same upstream license as the upstream one. In nebula, upstream is MIT licensed, but the latter is GPL-2 -- please change that. You are also patching the code with a GPL licensed diff, and that might not be acceptable by FTP masters In general, it should have same license to debian/ dir for minimal noise Other than than, your package looks very good. I must admit, this is not an easy package for a novice (as you mentioned) but this looks good, and very close to what I'd upload. You learnt stuff very, very quickly and this work is indeed very high quality. I'm quite impressed by your skills, for they are just amazing! :-) Please push your packages to team, and I'll take a final look and upload (hopefully by today EOD) Nilesh
Attachment:
signature.asc
Description: OpenPGP digital signature