Re: Errors Packaging Nebula
Hi Nilesh,
> I think you also need a build-dep-resolver
> For me, this works:
>
> sbuild -j5 -d unstable --source-only-changes --no-clean-source --run-lintian --lintian-opts='--color always --display-info --display-experimental --pedantic' --extra-package=/path/to/golang-github-nbrownus-go-metrics-prometheus-dev_0.0\~git20210317.6474303-1_all.deb --extra-package=/path/to/flynn/golang-github-flynn-noise-dev_1.0.0-1_all.deb --extra-repository='deb http://ftp.us.debian.org/debian experimental main' --build-dep-resolver=aptitude
This worked! HEAD is currently building using sbuild.
>>
>> There are still a couple Lintian issues I can't nail down. First, debuild
>>
>> emits hardening warnings for all the binaries in Nebula:
>>
>> - nebula: hardening-no-pie usr/bin/nebula
>>
>> - nebula: hardening-no-relro usr/bin/nebula
> Right, that's likely probably because you have hard-coded golang-1.16 in d/control.
> That's kind of very fragile since this would break at some point in time.
>
> I told Peymaneh about it in this email[2] and replacing it by golang any fixed it for them, see
> here[3]
>
> But here the problem is that nebula does not build with golang-any (or effectively golang-1.15) hence
> we might have to wait for bullseye release and then for 1.16 to become default.
>
> OR
>
> Could you instead package version 1.3.0 for nebula with golang-any as B-D?
> If that fixed it, we'll upload 1.3.0 for now, and we'll simply upgrade to latest when the above issues
> are fixed -- what say?
I wrote a trivial patch that makes it 1.13 compatible.
>> It also complains that no manual pages are included. Although, the
>> project hasn't
>>
>> produced any to my knowledge.
> If nebula supports -h/--help option, you might want to create maintainer manual pacges via help2man and forward that upstream.
> This handy script might help you[3]
I did this; it's now on salsa.
>>> I have a few reviews on these. First off, there's just one "main"
>>> branch. This goes against the way go team packages should be
>>> maintained.
>>>
>>> There's a debian/sid branch, along with an upstream branch. It also
>>> seems like you used dh-make for nebula, please consider to use
>>> dh-make-golang.
>> I recreated all the repositories with dh-make-golang. The version of
>>
>> the tool in unstable automatically setup these branches. Given that
>>
>> they are completely new git repos (although I kept the paths the same),
>> you'll
>>
>> probably want to clone them again.
> I will grant you push access to the team after a few more reviews so they are at a central place
Sounds good.
Let me know if we need to make any other changes.
Best,
Alex
Reply to: