Re: Do go source packages normally contain test code?
On Thu, Mar 21, 2019 at 8:39 PM Dawid Dziurla <dawidd0811@gmail.com> wrote:
>
> I would say that you should not exclude this test/ directory because it is used in test suite of the source package which is vital.
>
> But maybe someone more experienced could say something about it.
OK. I'll wait and see. BTW, I come up with the idea because I read the
following the other day:
It's said on https://go-team.pages.debian.net/packaging.html that,
Libraries written in Go are packaged for Debian with the only purpose
of building other Go programs for Debian. They are specifically not
available for users in their regular development workflow...
Because when building the source, all test has to be passed before it
succeed, even the test/ is eventually excluded from the source
package.
> On March 22, 2019 1:07:05 AM GMT+01:00, Tong Sun <suntong001@users.sourceforge.net> wrote:
>>
>> I thought so, as I copied it from
>>
>> https://salsa.debian.org/go-team/packages/git-lfs/blob/master/debian/rules#L6
>>
>> However, I just verified again that it is not meant to exclude test
>> from the source package. See
>> http://paste.debian.net/1074164/
>>
>> It not even prevent copying test to temporary build directory BTW, as
>> if I remove the "export DH_GOLANG_INSTALL_EXTRA := test" from my rules
>> file,
>> https://salsa.debian.org/go-team/packages/easygen/blob/master/debian/rules
>>
>> the build will still fail.
>>
>> I guess it does just "exclude from the build targets".
>>
>> So again,
>>
>> Shall I exclude test from my source package?
>>
>> On Thu, Mar 21, 2019 at 7:46 PM Dawid Dziurla <dawidd0811@gmail.com> wrote:
>>>
>>>
>>> Should be okay. If not, try putting it between double quotes.
>>>
>>> If I understand correctly, it excludes files to be copied to temporary build directory.
>>>
>>> On March 22, 2019 12:41:16 AM GMT+01:00, Tong Sun <suntong001@users.sourceforge.net> wrote:
>>>>
>>>>
>>>> Hi,
>>>>
>>>>> Do go source packages normally contain test code?
>>>>
>>>>
>>>>
>>>> I tried to add the following to my rules file
>>>>
>>>> export DH_GOLANG_EXCLUDES := test vendor
>>>>
>>>> Is that the correct way to go?
>>>>
>>>> "DH_GOLANG_EXCLUDES" (list of Perl regular expressions,
>>>> whitespace-separated, default empty) defines regular expression
>>>> patterns to exclude from the build targets expanded from
>>>> "DH_GOLANG_BUILDPKG".
>>>>
>>>> I'm still don't understand what it is for, as I noticed that the test
>>>> folder and its files are still in the source packages. What does
>>>> DH_GOLANG_EXCLUDES do exactly?
>>>>
>>>> thx
>>>
>>>
Reply to: