Re: opencpn (was: opencpn: binaries without source)
On 11/29/18 9:33 AM, Alec Leamas wrote:
> On 25/11/18 14:58, Sebastiaan Couwenberg wrote:
>> There has been no upload of the package yet, so the +dfsg
>> repacksuffix is sufficient, the .1 should be stripped.
>
> What about [1]? What's the reason to not comply with this?
That's just one of the forms that can be used, and one which we don't
use for any of our packages.
You generally don't have to repack the same upstream release more than
once, so no repacking revision is required. When it it, you can change
+dfsg to +dfsg1.
>> The opencpn-plugins package depends a manual version, it should
>> ${binary:Version} instead.
>
> Isn't this the merge case #6 in [2]? Where the version is hardcoded?
While specifying the minimum version required it sufficient, it's
cleaner to have inter dependencies use the version of the package.
>> Why is the get-orig-source target used? The bugreport mentioned is
>> not clear.
>
> The short story is that a plain uscan doesn't work, and that this is a
> known problem. It seems to be related to large sources generated with
> something else than a recent gnu tar. The work-around is basically to
> unpack and repack with gnu tar at which point things can proceed as usual.
Plain uscan will work with the release tags.
There are a few issues with repacking not being done, e.g. when using
`gbp import-orig --uscan` so executing uscan & gbp separately ensures
they both do the right thing.
>> Why add an override for the javascript files when they can be
>> excluded from the repacked upstream tarball?
>
> Because all other things removed are supported by build system patches
> which have been upstreamed. Patches for removing these files will never
> be accepted, and likely a pain to maintain.
You don't need patches to remove those unused files, you add them to
Files-Excluded in debian/copyright.
If the patches to use packaged versions of those projects won't be
accepted by upstream, mark them as Forwarded: not-needed.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Reply to: