Re: upgrade orfeotoolbox to 5.0
Hi Rashad,
Here's my review of the lintian issues as promised.
Splitting the libraries into separate binary packages with symbols will
get rid of 39 lintian issues.
Making sure the binary package names match the SONAME will get rid of
the lintian warning for another three packages:
W: otb-bin-qt: package-name-doesnt-match-sonames libOTBQtWidget-5.0-1
W: otb-bin: package-name-doesnt-match-sonames libOTBCommandLine-5.0-1
libOTBCommandLineParser-5.0-1
W: libotb: package-name-doesnt-match-sonames
libOTBApplicationEngine-5.0-1 libOTBCarto-5.0-1 libOTBCommon-5.0-1
libOTBCurlAdapters-5.0-1 libOTBEdge-5.0-1 libOTBExtendedFilename-5.0-1
libOTBFuzzy-5.0-1 libOTBGdalAdapters-5.0-1 libOTBIOBSQ-5.0-1
libOTBIOGDAL-5.0-1 libOTBIOKML-5.0-1 libOTBIOLUM-5.0-1
libOTBIOMSTAR-5.0-1 libOTBIOMW-5.0-1 libOTBIOONERA-5.0-1
libOTBIORAD-5.0-1 libOTBIOTileMap-5.0-1 libOTBImageBase-5.0-1
libOTBImageIO-5.0-1 libOTBImageManipulation-5.0-1 libOTBMathParser-5.0-1
libOTBMetadata-5.0-1 libOTBOSSIMAdapters-5.0-1
libOTBOpenThreadsAdapters-5.0-1 libOTBPolarimetry-5.0-1
libOTBProjection-5.0-1 libOTBRCC8-5.0-1 libOTBStreaming-5.0-1
libOTBSupervised-5.0-1 libOTBTestKernel-5.0-1 libOTBTransform-5.0-1
libOTBVectorDataBase-5.0-1 libOTBVectorDataIO-5.0-1 libOTBWavelet-5.0-1
libotbossimplugins-5.0-1 libotbsiftfast-5.0-1
The missing manpages for the simple commandline utilities still need to
be added, or the lintian issues overridden if there's a good reason to
not have a manpage for these:
W: otb-bin-qt: binary-without-manpage usr/bin/otbApplicationLauncherQt
W: otb-bin: binary-without-manpage usr/bin/otbApplicationLauncherCommandLine
W: libotb: binary-without-manpage usr/bin/otbTestDriver
All the spelling errors reported by lintian were addressed in one my
recent pushes, these three remaining false positives can be ignored:
I: otb-bin-common: spelling-error-in-binary
usr/lib/otb/applications/otbapp_TrainImagesClassifier.so algoritH algorithm
I: otb-bin-common: spelling-error-in-binary
usr/lib/otb/applications/otbapp_VertexComponentAnalysis.so tEH the
I: libotb: spelling-error-in-binary
usr/lib/x86_64-linux-gnu/libotbossimplugins-5.0.so.1 TeH The
The two hardening-no-fortify-functions issues are false positive, so
I've added lintian overrides for these:
I: libotb: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/libOTBIOMSTAR-5.0.so.1
I: libotb: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/libOTBVectorDataBase-5.0.so.1
The .hg* files can also be added to Files-Excluded to get rid of this,
but it's not strictly required:
P: otb source: source-contains-hg-tags-file .hgtags
These are easy to fix by installing RELEASE_NOTES.txt as the upstream
changelog by overriding dh_installchangelogs:
P: python-otb: no-upstream-changelog
P: otb-bin-common: no-upstream-changelog
P: libotb-dev: no-upstream-changelog
P: otb-bin-qt: no-upstream-changelog
P: otb-bin: no-upstream-changelog
P: libotb: no-upstream-changelog
These are caused by the missing dependency on otb-bin{,-qt} for
libotb-dev, this is another reason to split the libraries into separate
packages and have libotb-dev depend on all of them:
X: libotb-dev: package-contains-broken-symlink
usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so libOTBCommandLine-5.0.so.1
X: libotb-dev: package-contains-broken-symlink
usr/lib/x86_64-linux-gnu/libOTBCommandLineParser-5.0.so
libOTBCommandLineParser-5.0.so.1
X: libotb-dev: package-contains-broken-symlink
usr/lib/x86_64-linux-gnu/libOTBQtWidget-5.0.so libOTBQtWidget-5.0.so.1
This concludes my review of the lintian issues, please have a look at
these. Addressing the shared libraries will get rid of most outstanding
issues.
The updated spelling patch also still needs to be forwarded upstream.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Reply to: