josm + jmapviewer 1.03 (was: Re: jmapviewer 1.03)

[Felix Natter <fnatter@gmx.net>]

Felix Natter <fnatter@gmx.net> writes:

> hi GIS Team,
>
> I took over maintainership of jmapviewer (1.02 at the time) a while ago,
> and since then David Paleino updated the package to
> "1.02+svn30322.really+dfsg1-1" because josm requires a newer version.
>
> Now 1.03 has been released [1], and I need to fix this (Depends:
> openjdk-7-jre => default-jre), so the question is whether I should
> upgrade the package to 1.03 now (1.03 is svn30431 so the changes
> necessary for josm should be included?).
>
> The reverse dependencies are:
> - josm
> - freeplane (which I maintain)
> - gis-osm (Suggests)
>
> For freeplane I had to fix things a bit:
>
>   map.setDisplayPositionByLatLon(new Point(map.getWidth() / 2,
>     map.getHeight() / 2), location.getLat(), location.getLon(), zoom);
>
> becomes:
>
>   int x = (int)OsmMercator.LonToX(location.getLon(), zoom);
>   int y = (int)OsmMercator.LatToY(location.getLat(), zoom);
>   map.setDisplayPosition(new Point(map.getWidth() / 2, map.getHeight() / 2), x, y, zoom);
>
> If you agree, then I will do this at the latest for the freeplane
> 1.3.x release.

Dear GIS Team / josm maintainers,

due to a misunderstanding between Andreas and me, jmapviewer has already
been upgraded to 1.03 in unstable :-/

Now I wanted to at least file bugs against josm if it FTBFS with
jmapviewer-1.03. josm doesn't currently build on unstable:

$ sudo apt-get build-dep josm
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Build-Depends dependency for josm cannot be satisfied because candidate version of package libmetadata-extractor-java can't satisfy version requirements

In testing/jessie, josm fails to build with jmapviewer 1.03:

    [javac] /home/felix/src/josm/josm-0.0.svn6502+dfsg3/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java:50: error: RenamedSourceDecorator is not abstract and does not override abstract method YToLat(int,int) in TileSource
    [javac]     public static class RenamedSourceDecorator implements TileSource {
    [javac]                   ^
    [javac] /home/felix/src/josm/josm-0.0.svn6502+dfsg3/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java:376: error: possible loss of precision
    [javac]         int y1 = OsmMercator.LatToY(bbox.getMinLat(), MAX_ZOOM);
    [javac]                                    ^
    [javac]   required: int
    [javac]   found:    double
    [javac] /home/felix/src/josm/josm-0.0.svn6502+dfsg3/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java:377: error: possible loss of precision
    [javac]         int y2 = OsmMercator.LatToY(bbox.getMaxLat(), MAX_ZOOM);
    [javac]                                    ^
    [javac]   required: int
    [javac]   found:    double
    [javac] /home/felix/src/josm/josm-0.0.svn6502+dfsg3/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java:378: error: possible loss of precision
    [javac]         int x1 = OsmMercator.LonToX(minLon, MAX_ZOOM);
    [javac]                                    ^
    [javac]   required: int
    [javac]   found:    double
    [javac] /home/felix/src/josm/josm-0.0.svn6502+dfsg3/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java:379: error: possible loss of precision
    [javac]         int x2 = OsmMercator.LonToX(maxLon, MAX_ZOOM);
    [javac]                                    ^
    [javac]   required: int
    [javac]   found:    double
[...]
(complete build log attached)

--> Shall I create a bug report against josm for that or is it fixed in
    experimental (which I haven't tried)?
--> Do I have to do anything to prevent jmapviewer-1.03 from entering
    jessie?

Thanks for your understanding and Best Regards,
-- 
Felix Natter

Attachment: build.txt.gz
Description: application/gzip