[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Sponsering OpenCPN (Was: OpenStreetMap tile rendering stack in debian-gis)



Hi Hamish,

On Fri, Apr 19, 2013 at 03:10:20AM -0700, Hamish wrote:
> > Do you need a sponsor for your work?
> 
> if you have any spare time, I've been trying to get the finalized
> OpenCPN package sponsored by someone for almost a year.. (ITP# 538067)

Uhmm!  That's a real shame.  My main point behind the Blends concept was
to create teams inside Debian who work together in specific user
interests.  This fact proves somehow my suspicion that this idea is not
fully implemented in Debian GIS.  To stick to my word from regarding
"Sponsering of Blends"  I see that both criterions are fullfilled:

  a) http://svn.debian.org/viewsvn/pkg-grass/packages/opencpn/
  b) http://blends.alioth.debian.org/gis/tasks/workstation#opencpn

and so here I am having a look:

$ uscan --verbose --force-download
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   opts=dversionmangle=s/\+dfsg// http://sf.net/opencpn/OpenCPN-([\d\.]+)-Source\.tar\.gz
-- Found the following matching hrefs:
     OpenCPN-3.2.0-Source.tar.gz
     OpenCPN-3.0.0-Source.tar.gz
     OpenCPN-2.5.0-Source.tar.gz
     OpenCPN-2.3.1-Source.tar.gz
     OpenCPN-2.3.0-Source.tar.gz
Newest version on remote site is 3.2.0, local version is 2.5.0+dfsg
 (mangled local version number 2.5.0)
 => Forcing download as requested
-- Downloading updated package OpenCPN-3.2.0-Source.tar.gz


I just want to know whether upstream has just moved forward over this
longish (and admittedly frustrating time for you) or whether you
intentionally decided to package 2.5.0.  I would not question the later
because I admit I'm not that deep into GIS to know the differences but
before I go on sponsering I want to make sure I'll grab the right
package.

Moreover you have injected a +dfsg suffix that lets me assume you are
repackaging upstream tarball for some reason.  Usually this is
accompanied by some get-orig-source target in debian/rules to enable
others reproducing this step.  If it is simply about removing some files
you might like to follow the uscan enhancement I proposed[1] which does
simplify this process for the developer and makes it more transparent.

As far as I can see (at least from downloading 3.2.0 source) the "binary
without source" in wxWidgets should be removed.  Reading #538067 log it
seems that the "images without license" issue might be solved - but I
have not yet inspected the tarball deeply.

I also noticed that you have put some MD5SUM files into the tarballs
directory in SVN.  Please note that it is close to impossible to have
MD5SUM identical tarballs when changing anything in a tarball.  (There
was some relevant discussion on debian-devel@l.d.o.)  In other words:
Somebody who re-runs your (to be provided) get-orig-source target will
get a different MD5SUM (even if the untared dirs are byte identical).

In short: If you want your sponsor using the same tarball as you it is
better to provide a link[2] or use mentors.debian.net.  I for myself
(and in Debian Med team in general - Debian GIS might be different)
prefer a recipe who to recreate the tarball.

Regarding your packaging:

debian/rules:

I have read in the log of #538067 you were advised to remove third party
code in

  override_dh_auto_configure:

Just for the record:  I do not fully support this way because the
package will fail to build twice in a row because of the removed files.
So the cleanest way would be to move the files in
override_dh_auto_configure: out of the way and restore them if needed
in override_dh_auto_clean:.  I will not insist on this nitpicking,
just mentioning it.

I noticed your commented flags to enable hardening.  IMHO you could
safe a lot of this stuff by using debhelper compat level 9 which
cares for hardening automatically.

I was able to build the package with no lintian issues (except
hardening) and if you confirm the proper version you want me to sponser
I would have a more detailed look.

> I'd pretty much given up trying until the release freeze was over,
> the fastest option was looking like me going through the DD process
> myself.

I wished people would not have a reason to give up.  Becoming a DM
(first DM than DD) is a good idea anyway. 

Kind regards

         Andreas.

[1] https://wiki.debian.org/UscanEnhancements
[2] http://pkg-grass.alioth.debian.org/tarballs/opencpn_2.5.0+dfsg.orig.tar.gz

-- 
http://fam-tille.de


Reply to: