[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-grass-general] Re: DebianGis: Packaging postgis/geos



On Mon, 1 Nov 2004 21:31:01 +0100 (CET), Jochen Friedrich <jochen@scram.de>
wrote:
> Some comments about the package:
> 
> - the package must build automatically. This means: either postgis can
>   be compiled using the include files and libs provided by postgresql-dev.
>   Or you need to create an combined package of both postgresql and
>   postgis sources. You might use dbs for this purpose (the build system
>   also used by postgresql).

Postgis needs the makefiles framework of postgresql, but postgresql-dev doesn't
provide all needed files.
I assumed that source package could relay on the presence of environment
variable PGSQL_SRC at least.
I dont like very much the idea to repackage a postgresql source for
postgis, so I'd
prefere try that as last resort.

> - libgeos-dev and proj are missing in the build deps. You might want to
>   use pbuilder to check for complete build dependencies.

I was experimenting with pbuilder but I wasn't ready to use it when I submitted
the package to the list.

> - you ship empty /usr/lib/postgres/lib and /usr/lib/postgres/bin/
>   directories. You should remove them from debian/dirs.

Ok. I wrote "postgres" instead of "postgresql", anyway I'm removing them.
(Isn't lintian supposed to notice that kind of errors?).
 
> - debian/copyright should include the actual copyright. This seems to be
>   the following line:
> 
> Copyright 2001-2003 Refractions Research Inc.

Ok.

> - it would be nice to have doc/html/postgis.html and the examples in the
>   package.

Ok.

> Besides this, it looks Ok so far.
> 
> Thanks,
> Jochen

Thank you, I found your suggestions very helpful.
I'll submit a new package when I find how to resolve the source problem.

Regards,
Roberto

-- 
Roberto Boati <roberto.boati@gmail.com>
Daisy Red - http://www.daisyred.it



Reply to: