Re: please don't break GCC snapshot builds

[Ludovic Brenta <ludovic@ludovic-brenta.org>]

On Fri, 25 Apr 2014 15:37:38 +0100, Ludovic Brenta wrote:
> Matthias Klose wrote:
> > Please don't break GCC snapshot builds by not applying needed
> > patches for the snapshot builds.  At least the ppc64el build is
> > broken, now fixed in the vcs.  I didn't check other targets like,
> > arm, mips, the Hurd and KFreeBSD.
>
> Could you please elaborate on what exactly caused the breakage? I
> specifically made as many patches as possible unconditional and
> applied them as early as possible.  You moved ada-ppc64el from
> unconditional, early to unconditional, late.  Therefore I assume that
> there is a conflict between ada-ppc64el and some other patch that is
> applied only on snapshot builds?  Perhaps the problem is with this
> other patch, then?

Actually I noticed the following only now:

[lots of patches including all Ada- and Go-related patches...]

# all patches below this line are applied for gcc-snapshot builds as 
well
ifeq ($(single_package),yes)
  debian_patches =
endif

[more patches]

I think this construct is *extremely* error-prone; this line blindly
erases the carefully-crafted debian_patches variable and starts
afresh.  In my opinion, the only patches that should be applied only
on the stable branch are svn-updates.diff and the various backporting
patches; and this should be made more obvious from the names of the
variables.  For example:

stable_only_patches = \
  svn-updates \
  $(if $(with_linaro_branch),gcc-linaro-revert) \
  $(if $(with_linaro_branch),gcc-linaro) \

all_branch_patches = gcc-textdomain # note: currently "stable only"; 
why?
[...]

# No more patches beyond this line!

ifeq ($(single_package),yes)
  debian_patches = $(all_branch_patches)
else
  debian_patches = $(stable_only_patches) $(all_branch_patches)
endif

--
Ludovic Brenta.