Bug#969462: marked as done (elpa-pdf-tools: annotation editing broken with emacs 27.1)
Your message dated Sun, 13 Sep 2020 11:03:39 +0000
with message-id <E1kHPnH-00087D-Hr@fasolo.debian.org>
and subject line Bug#969462: fixed in emacs-pdf-tools 1.0~20200512-2
has caused the Debian Bug report #969462,
regarding elpa-pdf-tools: annotation editing broken with emacs 27.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
969462: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969462
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: elpa-pdf-tools
Version: 0.90-3
Severity: important
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
The function display-buffer-split-below-and-attach in pdf-utils.el
calls the (presumably internal) function window--display-buffer with 5
arguments, when it expects 3 to 4 in emacs 27.1.
This is fixed upstream. Probably we should update to a git snapshot
(it's been about 18 months since 0.90 was tagged).
Unfortunately a simple update to the latest from upstream git failed
for me because of apparent changes to the upstream build system.
What did work for me was just replacing the definition of
display-buffer-split-below-and-attach with the one from upstream master.
Let me know if you intend to update pdf-tools to a new upstream
version. If not I (or someone) can upload a patched version of 0.90
- ----------------------------------------------------------------------
To reproduce
1) start emacs -q
(load-library "pdf-tools-autoloads")
(pdf-tools-install)
2) make an annotation (I tried text and highlight style). Try to activate it. Observe the error message
display-buffer-split-below-and-attach: Wrong number of arguments: (3 . 4), 5
3) replace the definition of display-buffer-split-below-and-attach
(defun display-buffer-split-below-and-attach (buf alist)
"Display buffer action using `pdf-util-window-attach'."
(let ((window (selected-window))
(height (cdr (assq 'window-height alist)))
newwin)
(when height
(when (floatp height)
(setq height (round (* height (frame-height)))))
(setq height (- (max height window-min-height))))
(setq newwin (window--display-buffer
buf
(split-window-below height)
'window alist))
(pdf-util-window-attach newwin window)
newwin))
- -- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages elpa-pdf-tools depends on:
ii elpa-let-alist 1.0.6-2
ii elpa-pdf-tools-server 0.90-3+b1
ii elpa-tablist 1.0-1
ii emacs 1:27.1+1-1
ii emacs-gtk [emacs] 1:27.1+1-1
ii emacsen-common 3.0.4
elpa-pdf-tools recommends no packages.
elpa-pdf-tools suggests no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAl9Q6+EACgkQA0U5G1Wq
FSE6DQ//V1BNssr3PIKzbPdOVKyAkyAnG67fwmvUpUVo6jDcsGjg51VAHzdwXf4o
+unjqCDksZtdToJRw91AeidLAirnXvntPc834V9AG9qSRjjxPId2JdTlhaH4BMy1
A5HiFgDkhSc2Y2NLwa7RSABnGpK2kyEFDzZGnUexygcb25lZiF7xXCKDGNeaR620
psIyf+dMS6EOtW1C+SEEf9e8fAnqhsm37+beENBtlqlcEdSdapAbStAiosiWwT62
TAudI5SD6OFAAKFOpjo/nab4VzYh4xczMch+yxGmCe4833ckb9S5xOdY+NbgPEVn
rNKTYLGj3IvEbeUn7dbKZpMYvsKTiLYjzYL2ROwIV+UE3rBsv2t3l04zE6pwY8JF
+g9rXUE0GAjY4l15NLxmZ4guu9kQ6NN/jKTyKbaijQ2UCWBm13bVTW80EBecjniJ
uAkuZgvl6+kZJ/8fQ5uosDoquASPH7h+XIW1HDPvMvmJZ37C/0WkRttsvUNLCci4
9/GmT+kAotlmfOSEx9j5iGOmHwdsUaERvuljdqp++24gNMGTAczf4jzrSALYS8zP
27HHWAACMYiy8nECt6eusyjhFKsgPIG3YqRB34o0vfXdjEfDeE875rGdklfropkO
1Ufhp8TalE4El0iGEKxWJ8AcUPXB/tQ8FpV1q73H2ZnL5+Eujbw=
=Y+Dl
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Source: emacs-pdf-tools
Source-Version: 1.0~20200512-2
Done: David Bremner <bremner@debian.org>
We believe that the bug you reported is fixed in the latest version of
emacs-pdf-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 969462@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Bremner <bremner@debian.org> (supplier of updated emacs-pdf-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 13 Sep 2020 07:43:03 -0300
Source: emacs-pdf-tools
Architecture: source
Version: 1.0~20200512-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Emacs addons team <debian-emacsen@lists.debian.org>
Changed-By: David Bremner <bremner@debian.org>
Closes: 969462 969537
Changes:
emacs-pdf-tools (1.0~20200512-2) unstable; urgency=medium
.
* Team upload
* Upload to unstable
.
emacs-pdf-tools (1.0~20200512-1) experimental; urgency=medium
.
* Team upload
* New upstream snapshot. Bug fix: "annotation editing broken with emacs
27.1" (Closes: #969462).
* Drop patch fix-for-new-libsynctex; equivalent is upstream now.
* Add versioned depends on libpoppler-glib8 (Closes: #969537).
Checksums-Sha1:
231226f490b1d37f9807d0d453070b4abf69481a 2362 emacs-pdf-tools_1.0~20200512-2.dsc
087346f60e14acc1a7a1bdd47b772053f436196c 5196 emacs-pdf-tools_1.0~20200512-2.debian.tar.xz
Checksums-Sha256:
dd44ee34e044d6dc41f2cb8ebf1a7ec403945ac7d27e97b67836ed91c15179ad 2362 emacs-pdf-tools_1.0~20200512-2.dsc
695dda0864922cbf09ddfaf0d17b3554cff3963780e963fb9a4edd51ae0bb5b3 5196 emacs-pdf-tools_1.0~20200512-2.debian.tar.xz
Files:
7bd4f0dc77055534b92cde6a1f31fa7e 2362 text optional emacs-pdf-tools_1.0~20200512-2.dsc
fbb9a097e2cb8e98199fa9dded40f260 5196 text optional emacs-pdf-tools_1.0~20200512-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAl9d+HsACgkQA0U5G1Wq
FSEG9Q//RlB3uXJxVz3nz/liJ+XLLlLPiShKtJ2WtLyBnYeg1teIoPz+WRGsqRuz
glsl1s3QWsZ5l1JHmaEeK4su4K5n17Hnj5fTC+AdWeI4UrwT8czulESoczcGlBdz
/1JNUE2P3Jt3E48/xlzAunOwxd7mE5BMFV6zZM+HgxC6WvKVeODOGcSUWJT61y09
AajaZF85N9WWtyyhraAnEGRjmWNZb99fvNq5kBKEVSnGNc8lR049SkEN4ePXgpxu
h57UlH1Km93U5fM9BEyE2N4AnJk1NBCmRjNy4A/8ooDlK+6XkbzKkLb/JUxJSM0m
hPckmXbsAMxihEEa8TXvATQUFAU99laxCKkrQg5S3VEXdy1/I7yHLd2y7+AqqhA6
C985BHf5PNVodoBPiZj4iEmAEhB3dhpPJcI9Ef8OnJLMTtPHxZ8QtgRGBGJoFHMb
uYzg7wLTI4t8jnBwKIhmYxmdOHocKr/UR0S2goo/RSiLddNPTLBWZO6jz1uJVcTd
BamxZU+vCqMrm3SVr63OEXU7rH1c7WfnPA1/l0MuIwKtVjJLvYWcX1Owp2GOrsAo
RSStGlDHXx6AWbH7x7qhHoQbGJESeai6XkRur1Gqg+pyUZTs+ODT0Rn+cHRgmMyf
S3RMvF2WCtK9BBXLG2RxKeDZu5zhvNRoShT2c/4C2C4xeiGtZgI=
=jjnK
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: