Bug#969462: marked as done (elpa-pdf-tools: annotation editing broken with emacs 27.1)
Your message dated Sat, 05 Sep 2020 12:18:27 +0000
with message-id <E1kEX9H-0006km-GY@fasolo.debian.org>
and subject line Bug#969462: fixed in emacs-pdf-tools 1.0~20200512-1
has caused the Debian Bug report #969462,
regarding elpa-pdf-tools: annotation editing broken with emacs 27.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
969462: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969462
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: elpa-pdf-tools
Version: 0.90-3
Severity: important
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
The function display-buffer-split-below-and-attach in pdf-utils.el
calls the (presumably internal) function window--display-buffer with 5
arguments, when it expects 3 to 4 in emacs 27.1.
This is fixed upstream. Probably we should update to a git snapshot
(it's been about 18 months since 0.90 was tagged).
Unfortunately a simple update to the latest from upstream git failed
for me because of apparent changes to the upstream build system.
What did work for me was just replacing the definition of
display-buffer-split-below-and-attach with the one from upstream master.
Let me know if you intend to update pdf-tools to a new upstream
version. If not I (or someone) can upload a patched version of 0.90
- ----------------------------------------------------------------------
To reproduce
1) start emacs -q
(load-library "pdf-tools-autoloads")
(pdf-tools-install)
2) make an annotation (I tried text and highlight style). Try to activate it. Observe the error message
display-buffer-split-below-and-attach: Wrong number of arguments: (3 . 4), 5
3) replace the definition of display-buffer-split-below-and-attach
(defun display-buffer-split-below-and-attach (buf alist)
"Display buffer action using `pdf-util-window-attach'."
(let ((window (selected-window))
(height (cdr (assq 'window-height alist)))
newwin)
(when height
(when (floatp height)
(setq height (round (* height (frame-height)))))
(setq height (- (max height window-min-height))))
(setq newwin (window--display-buffer
buf
(split-window-below height)
'window alist))
(pdf-util-window-attach newwin window)
newwin))
- -- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages elpa-pdf-tools depends on:
ii elpa-let-alist 1.0.6-2
ii elpa-pdf-tools-server 0.90-3+b1
ii elpa-tablist 1.0-1
ii emacs 1:27.1+1-1
ii emacs-gtk [emacs] 1:27.1+1-1
ii emacsen-common 3.0.4
elpa-pdf-tools recommends no packages.
elpa-pdf-tools suggests no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAl9Q6+EACgkQA0U5G1Wq
FSE6DQ//V1BNssr3PIKzbPdOVKyAkyAnG67fwmvUpUVo6jDcsGjg51VAHzdwXf4o
+unjqCDksZtdToJRw91AeidLAirnXvntPc834V9AG9qSRjjxPId2JdTlhaH4BMy1
A5HiFgDkhSc2Y2NLwa7RSABnGpK2kyEFDzZGnUexygcb25lZiF7xXCKDGNeaR620
psIyf+dMS6EOtW1C+SEEf9e8fAnqhsm37+beENBtlqlcEdSdapAbStAiosiWwT62
TAudI5SD6OFAAKFOpjo/nab4VzYh4xczMch+yxGmCe4833ckb9S5xOdY+NbgPEVn
rNKTYLGj3IvEbeUn7dbKZpMYvsKTiLYjzYL2ROwIV+UE3rBsv2t3l04zE6pwY8JF
+g9rXUE0GAjY4l15NLxmZ4guu9kQ6NN/jKTyKbaijQ2UCWBm13bVTW80EBecjniJ
uAkuZgvl6+kZJ/8fQ5uosDoquASPH7h+XIW1HDPvMvmJZ37C/0WkRttsvUNLCci4
9/GmT+kAotlmfOSEx9j5iGOmHwdsUaERvuljdqp++24gNMGTAczf4jzrSALYS8zP
27HHWAACMYiy8nECt6eusyjhFKsgPIG3YqRB34o0vfXdjEfDeE875rGdklfropkO
1Ufhp8TalE4El0iGEKxWJ8AcUPXB/tQ8FpV1q73H2ZnL5+Eujbw=
=Y+Dl
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Source: emacs-pdf-tools
Source-Version: 1.0~20200512-1
Done: David Bremner <bremner@debian.org>
We believe that the bug you reported is fixed in the latest version of
emacs-pdf-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 969462@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Bremner <bremner@debian.org> (supplier of updated emacs-pdf-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 05 Sep 2020 08:52:01 -0300
Source: emacs-pdf-tools
Architecture: source
Version: 1.0~20200512-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Emacs addons team <debian-emacsen@lists.debian.org>
Changed-By: David Bremner <bremner@debian.org>
Closes: 969462 969537
Changes:
emacs-pdf-tools (1.0~20200512-1) experimental; urgency=medium
.
* Team upload
* New upstream snapshot. Bug fix: "annotation editing broken with emacs
27.1" (Closes: #969462).
* Drop patch fix-for-new-libsynctex; equivalent is upstream now.
* Add versioned depends on libpoppler-glib8 (Closes: #969537).
Checksums-Sha1:
40e7a199c4f3b3a4c46f72ee862eb14f8c1c1ab2 2362 emacs-pdf-tools_1.0~20200512-1.dsc
6b3c3964e0c4ca75cde6b40d69bcb472e053a6cb 399120 emacs-pdf-tools_1.0~20200512.orig.tar.xz
bdcd893eb0ffd2585eede387f07d37209e813e87 5184 emacs-pdf-tools_1.0~20200512-1.debian.tar.xz
Checksums-Sha256:
cdf44ae71edd486f496f37b346efcf40ee4ebc4c82e1baa825b3863270614bb7 2362 emacs-pdf-tools_1.0~20200512-1.dsc
15cd0872029fdcbbdba3e6e51b0148a279f0567f15acd7420aef791b2fd1ae81 399120 emacs-pdf-tools_1.0~20200512.orig.tar.xz
81e7bf7405269eeec5cd65f944761acdba15650b5af2f6776bb91dd5366d2643 5184 emacs-pdf-tools_1.0~20200512-1.debian.tar.xz
Files:
94bbd485ed70dd007dfd2677c095fcae 2362 text optional emacs-pdf-tools_1.0~20200512-1.dsc
0ca3b29c7bbada1a7380790bfac2a8ce 399120 text optional emacs-pdf-tools_1.0~20200512.orig.tar.xz
2ebcc3c92539bc2fb0bc367bfc25c23e 5184 text optional emacs-pdf-tools_1.0~20200512-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAl9TfZIACgkQA0U5G1Wq
FSHdQQ//T/QFDL1uL2IitTyljxS460ZXW8SDOGqz16PiPiryLIiRRoaV2SRifVap
qkzicRDnUdqtBYm0HLRT0UaldMV7xbV1iMMJGCa1LPhhKiwhtCxzoXv2O95iGvK9
Yoxa6Bq+mmpnEkZpGe9vxHUR6j/BFGnaZlNSJ7uea9cNDStTYgbJ+lwillQ16W3+
Rd3Su2AbEWhY47kB12sIny4xzGOoxdciQ7N9TJzwRLTTsuJyqtMs+NEAh+ScpxRL
NIWe5gPBqjDi1OD0U5hDBEm+52yS+kIAq9xjEj68PU8dhv3DJzr3mhDik3iIneck
7x2tSLX8XnMYyetDDxmZdOS2KGAIo4y1qQMPxsKVVPgarSdcJKaTfGnlX5AUowzo
CckqqbFoDRWwdhz4g9nlKwY25y0Zpje3ZpThMsCuPDNa1wc+ceiSbPDuLPsbSaoI
gor1SRkRUT1CbM7iyn1HKiExKD5Do7+2vBnosO/SvJ88SGHEQLD0Wr6oIYW0igBY
2taDbeFAvSLmee61PVZws+qzRINE/D04jL3A8K4I7Znk3xCfkRGaUgNyhVRHekuB
wG5DvWerQDrjxitCz9gLUXfYAUG2iI42f+rrBBmeeRS+UZovZsmfALx56JDzBuuc
IAHA0wIg+SZoBDKlJ0BoS0dAfIBra4f3o2JpcRcT9V5JNaRF1OA=
=R9nq
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: