Bug#969462: elpa-pdf-tools: annotation editing broken with emacs 27.1
Package: elpa-pdf-tools
Version: 0.90-3
Severity: important
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
The function display-buffer-split-below-and-attach in pdf-utils.el
calls the (presumably internal) function window--display-buffer with 5
arguments, when it expects 3 to 4 in emacs 27.1.
This is fixed upstream. Probably we should update to a git snapshot
(it's been about 18 months since 0.90 was tagged).
Unfortunately a simple update to the latest from upstream git failed
for me because of apparent changes to the upstream build system.
What did work for me was just replacing the definition of
display-buffer-split-below-and-attach with the one from upstream master.
Let me know if you intend to update pdf-tools to a new upstream
version. If not I (or someone) can upload a patched version of 0.90
- ----------------------------------------------------------------------
To reproduce
1) start emacs -q
(load-library "pdf-tools-autoloads")
(pdf-tools-install)
2) make an annotation (I tried text and highlight style). Try to activate it. Observe the error message
display-buffer-split-below-and-attach: Wrong number of arguments: (3 . 4), 5
3) replace the definition of display-buffer-split-below-and-attach
(defun display-buffer-split-below-and-attach (buf alist)
"Display buffer action using `pdf-util-window-attach'."
(let ((window (selected-window))
(height (cdr (assq 'window-height alist)))
newwin)
(when height
(when (floatp height)
(setq height (round (* height (frame-height)))))
(setq height (- (max height window-min-height))))
(setq newwin (window--display-buffer
buf
(split-window-below height)
'window alist))
(pdf-util-window-attach newwin window)
newwin))
- -- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages elpa-pdf-tools depends on:
ii elpa-let-alist 1.0.6-2
ii elpa-pdf-tools-server 0.90-3+b1
ii elpa-tablist 1.0-1
ii emacs 1:27.1+1-1
ii emacs-gtk [emacs] 1:27.1+1-1
ii emacsen-common 3.0.4
elpa-pdf-tools recommends no packages.
elpa-pdf-tools suggests no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAl9Q6+EACgkQA0U5G1Wq
FSE6DQ//V1BNssr3PIKzbPdOVKyAkyAnG67fwmvUpUVo6jDcsGjg51VAHzdwXf4o
+unjqCDksZtdToJRw91AeidLAirnXvntPc834V9AG9qSRjjxPId2JdTlhaH4BMy1
A5HiFgDkhSc2Y2NLwa7RSABnGpK2kyEFDzZGnUexygcb25lZiF7xXCKDGNeaR620
psIyf+dMS6EOtW1C+SEEf9e8fAnqhsm37+beENBtlqlcEdSdapAbStAiosiWwT62
TAudI5SD6OFAAKFOpjo/nab4VzYh4xczMch+yxGmCe4833ckb9S5xOdY+NbgPEVn
rNKTYLGj3IvEbeUn7dbKZpMYvsKTiLYjzYL2ROwIV+UE3rBsv2t3l04zE6pwY8JF
+g9rXUE0GAjY4l15NLxmZ4guu9kQ6NN/jKTyKbaijQ2UCWBm13bVTW80EBecjniJ
uAkuZgvl6+kZJ/8fQ5uosDoquASPH7h+XIW1HDPvMvmJZ37C/0WkRttsvUNLCci4
9/GmT+kAotlmfOSEx9j5iGOmHwdsUaERvuljdqp++24gNMGTAczf4jzrSALYS8zP
27HHWAACMYiy8nECt6eusyjhFKsgPIG3YqRB34o0vfXdjEfDeE875rGdklfropkO
1Ufhp8TalE4El0iGEKxWJ8AcUPXB/tQ8FpV1q73H2ZnL5+Eujbw=
=Y+Dl
-----END PGP SIGNATURE-----
Reply to: