Guillem Jover wrote: > On Wed, 2011-04-20 at 20:11:33 -0500, Jonathan Nieder wrote: >> +m4_pattern_forbid([^PKG_[A-Z_]+$], [missing some pkg-config macros]) > > The problem with this is that it's managing someone else's namespace, > which I don't think it's right. Instead I've just checked explicitly > if PKG_PROG_PKG_CONFIG is not defined. Thanks, Guillem. I agree with explanation and the fix you commited looks good.