Re: Insufficient check on pkg-config
On Wed, 2011-04-20 at 20:11:33 -0500, Jonathan Nieder wrote:
> Cyril Brulebois wrote:
> > not sure how you want to solve it, but autoreconf'ing without
> > pkg-config installed leads to a bad configure-time error.
> -- >8 --
> Subject: build: Catch attempts to autoreconf without pkg-config installed
> diff --git a/configure.ac b/configure.ac
> index 390a868..f8996e0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -6,6 +6,9 @@ AC_CONFIG_SRCDIR([lib/dpkg/dpkg.h])
> +m4_pattern_forbid([^PKG_[A-Z_]+$], [missing some pkg-config macros])
The problem with this is that it's managing someone else's namespace,
which I don't think it's right. Instead I've just checked explicitly
if PKG_PROG_PKG_CONFIG is not defined.
I've added a modified version of this though.