[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Some upcoming dpkg changes, test and feedback welcome



On Wed, 2011-09-21 at 09:02:39 +0200, Raphael Hertzog wrote:
> On Tue, 20 Sep 2011, Guillem Jover wrote:
> > > +# DEB_DISTRIBUTION: the first distribution of the current entry in debian/changelog
> > 
> > Why only the first, what makes it special? If there's multiple filter
> > can always be used.
> 
> So that a simple equality test does a good approximation of what was
> wanted in the few cases where there are multiple distributions. Because
> simple equality test is what people are going to do since 99% of real life
> usage in Debian implies a single distribution listed.
> 
> Otherwise everybody must always use filter and compare to the empty
> string.
> 
> In the rare case where someone really wants the multiple distributions,
> he can uses dpkg-parsechangelog directly.

Oh, but in Debian this should not happen as multiple distributions are
not supposed to be allowed [0]. And given that the package checks are
already Debian specific, say a safety net against uploading experimental
packages to unstable, it should be safe to assume there's only going
to be one distribution returned or the upload will fail anyway on DAK.
If the upload would succeed then the safety net would not actually be
safe as the order of the suites is not guaranteed.

So returning all the values is fine, and would be useful for other
derivatives where more than one is actually allowed, and for Debian
using equality should also be just fine (although using filter would
be more correct, would avoid archive checks assumptions and as such
catch possibly bogus uploads earlier).

regards,
guillem

[0] <http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Distribution>


Reply to: