[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#120152: Patch: sdiff support



On Sat, 15 Nov 2003, Josip Rodin wrote:

> On Sat, Nov 15, 2003 at 07:05:04PM +0200, Jarno Elonen wrote:
> >  * Enclosed file names with quotes in command string (Closes #147583)
>
> Umm...
>
> @@ -450,7 +450,7 @@
>                 if (!p || !*p)
>                         p=DEFAULTPAGER;
>
> -               sprintf(cmdbuf, DIFF " -Nu %.250s %.250s | %.250s", old, new, p);
> +               sprintf(cmdbuf, DIFF " -N \"%.250s\" \"%.250s\" | %.250s", old, new, p);
>
>                 s=getenv(SHELLENV);
>                 if (!s || !*s)

Note, that this kind of execing of external programs will no longer be
nescessary for the new dpkg.  It doesn't use the shell to run things, so there
are no quoting problems.




Reply to: