[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build



On Wed, Mar 31, 2010 at 04:46:00PM +0200, Mehdi Dogguy wrote:
> Julian Andres Klode wrote:
> > A 'debuild; debuild' should have a different result than a single
> > debuild then. If you build from a clean directory, the first build
> > will contain no changes. But after the build, the directory is not
> > clean anymore and debian/rules clean does not do enough to keep the
> > changes from appearing in the source package if you build again.
> > 
> 
> I should have done that earlier (but didn't see the git repo, only now). I
> had a look at dh-autoreconf's code and the difference between what I do
> and what your script does is that I manually specify a list of files to
> "monitor" while you monitor all files.
> 
> IMO, dh-autoreconf may be not specific to autoreconf but all same kind of
> tools and thus, can be enhanced by making, for example, the command to
> execute an argument which could be the command "true" (and keep
> "autoreconf" as a default) because, sometimes, it may be needed to make
> "debian/autoreconf.after" a bit later than just after executing
> "autoreconf". Hopefully, we can do that by overriding the file.

The idea is that I want to keep debian/autoreconf.{before,after}
only related to the autoreconf run.


> If you have these options, dh-autoreconf becomes nothing more than a call
> to autoreconf if we have dh_backup (name proposed by buxy in the same
> thread). dh_backup can be integrated to debhelper and all that remains to
> be done is a call to "autoreconf" (depending on the implementation of
> dh_backup).
A backup and restore approach is a completely different and more
complicated (in I/O sense) way than just deleting the files; e.g.
for a single file:

  dh_backup:
   1. mkdir()  - Create the backup directory
   2. read()   - Read the original source
   3. write()  - Write the backup file
   4. rename() - Rename backup to source

  dh_autoreconf:
   1. read()   - Create md5sum before (unneeded if --mode=timesize)
   2. read()   - Create md5sum after (unneded if --mode=timesize)
   3. unlink() - Unlink the changed file

Furthermore, the second read() in dh_autoreconf could also be in
the cache already.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Attachment: pgpra8kxkXtMB.pgp
Description: PGP signature


Reply to: