[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: This topic died off; any resolution?



Manoj Srivastava <srivasta@debian.org> writes:

>         Well, programs that extract these files can do so. But the thing
>  is, we can now make get-orig-source actually work with these external
>  script too:
>
> --8<---------------cut here---------------start------------->8---
> GET_SRC_VERSION  := $(strip $(shell LC_ALL=C dpkg-parsechangelog | \
>                        egrep '^Version:' | cut -f 2 -d ' '))
> get-orig-source: get-latest-source
>
> get-latest-source:
>         test ! -f debian/getsrc || test ! -x debian/getsrc || \
>                            chmod +x debian/getsrc
>         test ! -f debian/getsrc || ./debian/getsrc
>
> get-debian-source:
>         test ! -f debian/getsrc || test ! -x debian/getsrc || \
>                            chmod +x debian/getsrc
>         test ! -f debian/getsrc || \
>                  ./debian/getsrc --upstream-version $GET_SRC_VERSION
> --8<---------------cut here---------------end--------------->8---
>
>         ./debian/getsrc can then be "exec uscan $@", or something else.
>  We can have snippets setting GET_SRC_VERSION to what debian/changelog
>  has, or something else.
>
>         This is the best of both worlds, no? we have a common make
>  target, and we have a simply named script, that can be extracted.

At the cost of additional complexity of the specification, which I'm not
really happy about.  I'd rather standardize one single interface, not
require both interfaces be available with boilerplate glue.  Also, on a
similar complexity front, I'd rather decide which of the two
get-orig-source should be and not standardize both unless people see a
real need to have both of them).

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: