Mike Hommey wrote: > On Tue, Feb 10, 2009 at 12:03:27PM +0100, Loïc Minier wrote: >> On Tue, Feb 10, 2009, Josselin Mouette wrote: >>> I don’t think it’s a good idea to use triggers for >>> update-desktop-database. There are many .desktop files without a >>> MimeType key, and for all of them calling update-desktop-database is a >>> waste of time. >>> >>> On my system, only 30% of .desktop files have a MimeType field. If >>> anyone can make per-package statistics on the whole archive, that would >>> probably give a better picture. >> It's once per upgrade and ridiculously cheap; I don't think the waste >> of time is an argument. However this probably makes the direct calls >> in maintainer scripts as cheap. The only arguments in favor of >> triggers here are: >> - single place to fix/hack where all the calls are done >> - avoids a dh_foo call or custom hackery for packages not using >> debhelper >> and these aren't as compelling as the time to upgrade argument which is >> usually the reason for triggers. >> >> sudo update-desktop-database -q 0,06s user 0,02s system 96% cpu 0,075 total > > Is that with cold cache ? > It's also a matter for what case we optimize: For users running unstable, who constantly update, it might/will happen that the update-desktop-database trigger is activated although unnecessary. For stable users, who only do distro upgrades, it might be quite some benefit, as instead of dozens of update-desktop-database calls during the upgrade, you'd only get one. I let others decide what is more important. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature