--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: FTBFS with G++ 4.1: extra qualification
- From: Martin Michlmayr <tbm@cyrius.com>
- Date: Thu, 23 Mar 2006 12:12:44 +0000
- Message-id: <20060323121244.GB15698@deprecation.cyrius.com>
- In-reply-to: <E1FMJ5M-0006jp-WB@bigsur.cyrius.com>
- References: <E1FMJ5M-0006jp-WB@bigsur.cyrius.com>
Package: openbabel
Version: 2.0.0-1
Severity: important
Tags: patch
Your package fails to build with G++ 4.1. I'm filing this bug as
important for now, but when 4.1 will be the default compiler in
unstable (probably in a few weeks) I'll upgrade this to serious.
A patch is attached.
P.S. G++ and you don't stop (to fix bugs!)
> Automatic build of openbabel_2.0.0-1 on bigsur by sbuild/mips 1.106
...
> g++ -DHAVE_CONFIG_H -I. -I. -I../../../src -I../../../src -I../../../data -I/usr/include/libxml2 -g -Wall -O2 -MT cmlreactlformat.lo -MD -MP -MF .deps/cmlreactlformat.Tpo -c cmlreactlformat.cpp -fPIC -DPIC -o .libs/cmlreactlformat.o
> xml.h:44: error: extra qualification 'OpenBabel::XMLConversion::' on member 'SetupReader'
> xml.h:45: error: extra qualification 'OpenBabel::XMLConversion::' on member 'SetupWriter'
> xml.h:61: error: extra qualification 'OpenBabel::XMLConversion::' on member 'RegisterXMLFormat'
> xml.h:68: error: extra qualification 'OpenBabel::XMLConversion::' on member 'IsLast'
> xml.h:70: error: extra qualification 'OpenBabel::XMLConversion::' on member 'GetOutputIndex'
> xml.h:99: error: extra qualification 'OpenBabel::XMLConversion::' on member 'GetContent'
> xml.h: In member function 'void OpenBabel::XMLConversion::OutputToStream()':
> xml.h:82: warning: unused variable 'ret'
> cmlreactlformat.cpp: At global scope:
> cmlreactlformat.cpp:54: error: extra qualification 'OpenBabel::CMLReactFormat::' on member 'Flags'
> make[5]: *** [cmlreactlformat.lo] Error 1
> make[5]: Leaving directory `/build/tbm/openbabel-2.0.0/src/formats/xml'
--- ./src/formats/xml/xml.h~ 2006-03-23 12:07:03.000000000 +0000
+++ ./src/formats/xml/xml.h 2006-03-23 12:07:28.000000000 +0000
@@ -41,8 +41,8 @@
///Frees reader and writer if necessary
~XMLConversion();
- bool XMLConversion::SetupReader();///< opens libxml2 reader
- bool XMLConversion::SetupWriter();///< opens libxml2 writer
+ bool SetupReader();///< opens libxml2 reader
+ bool SetupWriter();///< opens libxml2 writer
///Parses the input xml stream and sends each element to the format's callback routines
bool ReadXML(XMLBaseFormat* pFormat, OBBase* pOb);
@@ -57,7 +57,7 @@
return *nsm;
};
- static void XMLConversion::RegisterXMLFormat(XMLBaseFormat* pFormat,
+ static void RegisterXMLFormat(XMLBaseFormat* pFormat,
bool IsDefault=false, const char* uri=NULL);
///Returns the extended OBConversion class, making it if necessary
@@ -65,9 +65,9 @@
///Because OBConversion::Convert is still using the unextended OBConversion object
///we need to obtain the conversion paramters from it when requested
- bool XMLConversion::IsLast()
+ bool IsLast()
{ return _pConv->IsLast(); }
- int XMLConversion::GetOutputIndex()
+ int GetOutputIndex()
{ return _pConv->GetOutputIndex(); }
@@ -96,7 +96,7 @@
string GetAttribute(const char* attrname);
///Sets value to element content. Returns false if there is no content.
- string XMLConversion::GetContent();
+ string GetContent();
///Sets value to element content as an integer. Returns false if there is no content.
bool GetContentInt(int& value);
--- ./src/formats/xml/cmlreactlformat.cpp~ 2006-03-23 12:07:38.000000000 +0000
+++ ./src/formats/xml/cmlreactlformat.cpp 2006-03-23 12:07:45.000000000 +0000
@@ -51,7 +51,7 @@
\n";
}
- unsigned CMLReactFormat::Flags()
+ unsigned Flags()
{
return 0;
}
--- ./src/formats/xml/xmlformat.cpp~ 2006-03-23 12:09:09.000000000 +0000
+++ ./src/formats/xml/xmlformat.cpp 2006-03-23 12:09:20.000000000 +0000
@@ -21,12 +21,12 @@
class XMLFormat : XMLBaseFormat
{
public:
- XMLFormat::XMLFormat()
+ XMLFormat()
{
OBConversion::RegisterFormat("xml",this);
}
- const char* XMLFormat::Description()
+ const char* Description()
{
return " \
General XML format\n \
@@ -40,7 +40,7 @@
const char* NamespaceURI()const{return "Undefined";};
- unsigned XMLFormat::Flags()
+ unsigned Flags()
{
return NOTWRITABLE;
}
--- ./src/formats/copyformat.cpp~ 2006-03-23 12:09:52.000000000 +0000
+++ ./src/formats/copyformat.cpp 2006-03-23 12:09:58.000000000 +0000
@@ -41,7 +41,7 @@
};
/////////////////////////////////////////////////////////////////
- virtual bool CopyFormat::WriteChemObject(OBConversion* pConv)
+ virtual bool WriteChemObject(OBConversion* pConv)
{
pConv->GetChemObject();//needed to increment pConv->Index
--- ./src/formats/crkformat.cpp~ 2006-03-23 12:10:29.000000000 +0000
+++ ./src/formats/crkformat.cpp 2006-03-23 12:10:34.000000000 +0000
@@ -61,8 +61,8 @@
virtual bool ReadMolecule(OBBase* pOb, OBConversion* pConv);
virtual bool WriteMolecule(OBBase* pOb, OBConversion* pConv);
- static bool CRK2DFormat::ReadCRK(std::istream &ifs,OBMol &mol,const char *classTag);
- static void CRK2DFormat::WriteCRK(std::ostream &ofs,OBMol &mol,bool GroupCharges);
+ static bool ReadCRK(std::istream &ifs,OBMol &mol,const char *classTag);
+ static void WriteCRK(std::ostream &ofs,OBMol &mol,bool GroupCharges);
};
--- ./src/fingerprint.h~ 2006-03-23 12:11:37.000000000 +0000
+++ ./src/fingerprint.h 2006-03-23 12:11:43.000000000 +0000
@@ -60,7 +60,7 @@
static double Tanimoto(const std::vector<unsigned int>& vec1, const std::vector<unsigned int>& vec2);
/// Inline version of Tanimoto() taking a pointer for the second vector
- static double OBFingerprint::Tanimoto(const std::vector<unsigned int>& vec1, const unsigned int* p2)
+ static double Tanimoto(const std::vector<unsigned int>& vec1, const unsigned int* p2)
{
///If used for two vectors, vec1 and vec2, call as Tanimoto(vec1, &vec2[0]);
int andbits=0, orbits=0;
--
Martin Michlmayr
http://www.cyrius.com/
--- End Message ---
--- Begin Message ---
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 14 May 2006 19:46:01 -0500
Source: openbabel
Binary: libopenbabel-dev libopenbabel1 openbabel
Architecture: source i386
Version: 2.0.1-1
Distribution: unstable
Urgency: low
Maintainer: Michael Banck <mbanck@debian.org>
Changed-By: Michael Banck <mbanck@debian.org>
Description:
libopenbabel-dev - Convert and manipulate chemical data files (development version)
libopenbabel1 - Convert and manipulate chemical data files
openbabel - Convert and manipulate chemical data files
Closes: 341628
Changes:
openbabel (2.0.1-1) unstable; urgency=low
.
* New upstream release. (Closes: #341628)
* debian/patches/04_zipstream_fix.diff: Removed, applied upstream.
* debian/rules (DEB_MAKE_CHECK_TARGET): Readded.
Files:
16676ad42bd9e38585bf09ab1ad5562f 634 science optional openbabel_2.0.1-1.dsc
843a8d46c56a204cf20500b29b5a79cc 2454398 science optional openbabel_2.0.1.orig.tar.gz
8bd4bd0a6d1bb48898a51a7bbe832950 2945 science optional openbabel_2.0.1-1.diff.gz
9e729eeaa2812fcd6fa918b49c7d7a9d 168092 science optional openbabel_2.0.1-1_i386.deb
d3dbff1ea20a8beae91965d565539e35 639344 libdevel optional libopenbabel-dev_2.0.1-1_i386.deb
3b1882490f2ca3f3d8c28731ba0e2674 4830386 libs optional libopenbabel1_2.0.1-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFEZ+TVmHaJYZ7RAb8RAorXAKC7GTE+TH/M0Tdh4+KOjsFV3puUFACgnoKW
Z7IzWfjJhKAuzSFfosUpCtM=
=pfbi
-----END PGP SIGNATURE-----
Accepted:
libopenbabel-dev_2.0.1-1_i386.deb
to pool/main/o/openbabel/libopenbabel-dev_2.0.1-1_i386.deb
libopenbabel1_2.0.1-1_i386.deb
to pool/main/o/openbabel/libopenbabel1_2.0.1-1_i386.deb
openbabel_2.0.1-1.diff.gz
to pool/main/o/openbabel/openbabel_2.0.1-1.diff.gz
openbabel_2.0.1-1.dsc
to pool/main/o/openbabel/openbabel_2.0.1-1.dsc
openbabel_2.0.1-1_i386.deb
to pool/main/o/openbabel/openbabel_2.0.1-1_i386.deb
openbabel_2.0.1.orig.tar.gz
to pool/main/o/openbabel/openbabel_2.0.1.orig.tar.gz
--
To UNSUBSCRIBE, email to debian-devel-changes-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
--- End Message ---