Re: New kernel headers break LVM build
On Thu, Nov 20, 2003 at 02:58:00PM +0100, Christoph Hellwig wrote:
> On Thu, Nov 20, 2003 at 01:53:03PM +0000, Patrick Caulfield wrote:
> > I've looked at this is some more detail and I think I can get away with just
> > asm-*/ioctl.h.
>
> Can't you just use <sys/ioctl.h> as you should?
Not as it stands, because the ioctl definitions in lvm.h are broken and the 2.6
ioctl.h files spot that. I suppose I could also fix those too. :(
Nobody wanted this soon did they ??
> > The 2.6 one doesn't work because it checks the last argument to
> > _IOWR etc which in lvm.h is set to "1" rather than a datatype <sigh>. liblvm.h
> > also includes linux/genhd.h
>
> what do you need from this file? just copy & pasting the few bits from
> there should be enough.
>
> > and linux/major.h which seem to be fairly clean for
> > further asm/ includes.
>
> I think the lvm userland only wants LVM_MAJOR from there and already
> handles the case of it not beeing present. In any case just copying the
> few FOO_MAJOR defintions sounds like the easiest idea..
Yeah maybe. It'll have to wait a while now though, this job gets bigger and
bigger!
--
patrick
Reply to: