Re: Bug#210650: libxine1: libraries not correctly linked
On Sat, 13 Sep 2003, Henrique de Moraes Holschuh wrote:
> Please fix the package. Upstream is doing things upstream thinks are right,
> which quite often is not the case within Debian. In this case, they are
> indeed quite wrong. You *HAVE* TO LINK ANY LIBRARIES YOUR LIB _MIGHT_ NEED
> AT INITIAL LINKING TIME.
Are you sure you have understood that xine lib MIGHT NOT EVEN POSSIBLY
EVER NEED any X libraries _unless_ the hosting application does use them
(and therefore is already linked against them, which makes them
available)?
Okay, that said, we were probably thinking about different parts of the
code: What I had in mind was the X related video output code in Xshm and
Xv plugins. These are in fact correctly linked.
The actual issue is the Xv checking code in src/xine-util/xine_check.c,
which must be explicitly called by the application as
xine_health_check(&result, CHECK_XV);
In that case, dlopen()ing the appropriate libs may in fact be the most
feasible solution, especially as the function is typically only called
once the first time user starts gxine. (Other front ends don't use this
health_check mess. Maybe disabling this code is a better idea...)
And yes, the current linkage is definitely wrong, as it gives a relocation
error, if you call xine_health_check(&result, CHECK_XV) without linking
your application to libX11 and libXext. (One could argue, though, that you
must not use the CHECK_XV option, unless you're using an X11 front end...)
Reply to: