[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

URGENT: Please evaluate this easy fix enabling wxgtk2.1 to build!

------- Forwarded Message

From: Jim Lynch <jim@laney.edu>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: [PATCH] will not build. Urgent!! Please test and evaluate this patch!!
Date: Sat, 27 May 2000 15:33:21 -0700

Package: wxgtk2.1
Version: 2.1.11-2
Severity: important

This should likely go upstream. This patch does not change API at all.

Will not build without this patch (It fits on a screenful; more text below!):

--- CUT HERE ---
diff -naur wxgtk2.1-2.1.11/src/gtk/dcclient.cpp wxgtk2.1-2.1.11-new/src/gtk/dcclient.cpp
--- wxgtk2.1-2.1.11/src/gtk/dcclient.cpp	Tue Nov  9 08:48:59 1999
+++ wxgtk2.1-2.1.11-new/src/gtk/dcclient.cpp	Sat May 27 05:15:57 2000
@@ -954,7 +954,7 @@
     if (req_dash && req_nb_dash)
-        char *real_req_dash = new char[req_nb_dash];
+        signed char *real_req_dash = new signed char[req_nb_dash];
         if (real_req_dash)
             for (int i = 0; i < req_nb_dash; i++)
@@ -965,7 +965,7 @@
             // No Memory. We use non-scaled dash pattern...
-            gdk_gc_set_dashes( m_penGC, 0, (char*)req_dash, req_nb_dash );
+            gdk_gc_set_dashes( m_penGC, 0, (signed char*)req_dash, req_nb_dash );
--- CUT HERE ---

PLEASE try to build this IMMEDIATELY!! It's very small and should be easy!
Maybe we can get it into the second test phase if it can be verified.

Especially important questions to ask: Why does wxwin choose to use signed
char * in method prototypes? It seems the new standard will cough when
you try to pass a char * through that; I have been told this is standard
c++ behavior (so it's -not- a compiler bug). I have the new language ref
and will research this if you want. The wxwin people should probably use
const char * for incoming C strings. But if they change that, they change
the API... Which, maybe, they should.

-- System Information
Debian Release: 2.2
Architecture: i386
Kernel: Linux earth 2.2.14 #1 SMP Wed Jan 26 19:25:48 PST 2000 i686

Versions of packages wxgtk2.1 depends on:
ii  libc6                         2.1.3-10   GNU C Library: Shared libraries an

------- End of Forwarded Message

Reply to: