Re: Release-critical Bugreport for January 7, 1999
kaih@khms.westfalen.de (Kai Henningsen) writes:
> > > Package: dpkg-dev (main)
> > > Maintainer: Klee Dienes and Ian Jackson
> > > <dpkg-maint@chiark.greenend.org.uk> 31508 parsechangelog broken?
[snip]
> Isn't that the bug where you have to
>
> $ LANG= dpkg-buildpackage
> or
> $ LANG= make-kpkg (just been bitten again by this one)
>
> because the script in question *STILL* tests for error message text
> instead of error number?
The one Enrique posted about in <19980215185959.39339@molec3>
_11 months_ ago?
It looks like it. The patch in the bug report avoids the problem
code. It might be valid, but the problem still exists.
> If that's the one, then I'd say that yes, this *is* release critical. It's
> also easy to fix; just evaluate $! in numerical context instead of string
> context and it gives the error number.
Like this?
--- controllib.pl.distrib Sun Sep 27 23:42:13 1998
+++ controllib.pl Sat Jan 9 23:17:38 1999
@@ -85,7 +85,7 @@
$substvar{$1}= $';
}
close(SV);
- } elsif ($! !~ m/no such file or directory/i) {
+ } elsif ($! != ENOENT) {
&error("unable to open substvars file $varlistfile: $!");
}
}
Before:
% LANG=de_DE dpkg-parsechangelog
parsechangelog/debian: error: unable to open substvars file debian/substvars: Datei oder Verzeichnis nicht gefunden
zsh: exit 2 LANG=de_DE dpkg-parsechangelog
After:
% LANG=de_DE dpkg-parsechangelog
Source: x3270
Version: 3.1.1.7-8
(etc.)
--
Carey Evans http://home.clear.net.nz/pages/c.evans/
Larry froze. Was the bag a trap?
He could see the way in, but the other end appeared to be sealed.
Reply to: