Bug#2647: cvs tag on nonexisting directory

[Bill Mitchell <mitchell@mdd.comm.mot.com>]

By copy of this email, I'm sending this bug report on to
the upstream maintainers of CVS.

Note to bug-cvs@prep.ai.mit.edu:  In responding by email,
please keep the Subject: line intact so that our bug
tracking system can process the response.

-------- cvs-1.7 bug report follows -----------

Submitter-Id:   mitchell@mdd.comm.mot.com
Originator:     tobias@et-inf.fho-emden.de
Organization:   debian.org
Confidential:   no
Synopsis:       cvs tag segfaults on nonexistent directory
Severity:       non-critical
Priority:       medium
Category:
Class:          sw-bug
Release:        cvs-1.7
Environment:
        i386, Linux 1.2.13, libc5-5.3.18
System: Linux S001 1.2.13 #4 Sun Nov 26 15:07:59 PST 1995 i386
Architecture: i386

Description:
 The following shows a cvs invocation which segfaults:

 root:cvs-1.7# src/cvs tag TEST non_existing_directory
 cvs tag: cannot open CVS/Entries for reading: No such file or directory
 Segmentation fault

How-To-Repeat:
 see above
Fix:
 it looks to me as if the cure for this is to change line 377 in
 entries.c, which reads:

        error (0, errno, "cannot open %s for reading", CVSADM_ENT);
to instead read:
        error (1, errno, "cannot open %s for reading", CVSADM_ENT);