[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Fwd: Re: [the3dfxdude/7kaa] Please use standard libuuid (#68)



Dear Games team,

Upstream included a modified version of libuuid in 7kaa (renaming the default type in every function). I asked (on this thread [1]) to let us use standard libuuid somehow.
You can read upstream's answer below.

What do you think about this ? Should we include this third party code, or should we try to remove it using our patches ?

Best regards,
Bertrand

[1] https://github.com/the3dfxdude/7kaa/issues/68


-------- Message transféré --------
Sujet : 	Re: [the3dfxdude/7kaa] Please use standard libuuid (#68)
Date : 	Wed, 14 Sep 2016 18:57:09 -0700
De : 	the3dfxdude <notifications@github.com>
Répondre à : 	the3dfxdude/7kaa <reply+00883cadb32202deee2ef77130ebb70570dbad3e6c637bb392cf0000000113f1c1f592a169ce0a885c11@reply.github.com>
Pour : 	the3dfxdude/7kaa <7kaa@noreply.github.com>
Copie à : 	beberking <bmarc@debian.org>, Author <author@noreply.github.com>



Sorry, this is not possible. The reason why the lib was integrated directly into the code base was to ensure full portability onto windows machines with stock windows libs
and no additional dependencies. The reason why e2fsprogs was used is that it was written in a more portable fashion to windows, and the forked libuuid repository broke some
of the original code. So e2fsprogs gave me a simpler starting point, and I made some additional changes to make it seemless.

Also, you got it a bit wrong, I did not start from the libuuid repository at all but extracted from e2fsprogs.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/the3dfxdude/7kaa/issues/68#issuecomment-247211637>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIg8rbEQsMvkeq2ZCC0XQ_PcicN4Jn2rks5qqKX1gaJpZM4J792D>.


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: