[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Xonotic: gmqcc package review



>>  Team, join to review :)
>
> This is not a review, but just few quick notes.

Few more tips:

> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/copyright;hb=HEAD

1) Please re-read document [1]. It recommends to use Expat license name instead
   of MIT.

2) Why do you use more strict license (GPL-2+) for debian package?
   It would be good idea to use the same license (Expat) as program uses.
   And debian/copyright file will become shorter. =)

[1] http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/rules;hb=HEAD

1) Please remove all comments. They are useless.

2) Is override_dh_auto_install really necessary? Have you tried to build the
   package without it?

Best wishes,
Boris


Reply to: