Re: RFS: trophy (New upstream)
Here is a review:
If you contact upstream at all as a result of the review below, please
point them at these docs:
http://www.freedesktop.org/wiki/Games/Upstream
http://wiki.debian.org/UpstreamGuide
You may want to run wrap-and-sort -s and manually wrap and sort the
Debian menu file.
Please add --parallel to the dh arguments, otherwise you are ignoring
DEB_BUILD_OPTIONS=parallel=n.
Please ask upstream to use run-time rendering of text using available
system TrueType fonts, since that allows for i18n. Seems like clanlib
supports this:
http://clanlib.org/wiki/MainDocs:Fonts
The following files contain pre-rendered text:
resources/fonts/*.tga
resources/gui/loading.tga
resources/menu/bg.tga
resources/panel/infoview.tga
resources/panel/label.tga
resources/panel/speed.tga
resources/panel/turbolabel.tga
The package descriptions of the -data and -dbg packages describe the
main package instead of themselves. See warzone2100 for an example of
how to do this.
The package descriptions have some slightly awkward grammar, you might
want to get debian-l10n-english to review them.
The upstream README file contains installation and build-time
requirements info, which are of no use to people using binary packages
on Debian. You may want to get upstream to split those out into
README.install or similar.
Please get the manual page included upstream.
debian/trophy.xpm is different to the upstream trophy.png. I would
suggest that debian/trophy.xpm should be created at build time, maybe
using imagemagick. This way it will always be up-to-date.
How about adding a longtitle to debian/trophy.menu? You can copy it
from the Comment in the trophy.desktop file.
A lot of the source code and data doesn't have any copyright notices
or license grants, you might want to get upstream to add those.
The following files didn't get installed in any package. In addition
they are installed in the wrong paths.
/usr/share/games/applications/trophy.desktop
/usr/share/games/icons/trophy.png
desktop-file-validate warning:
resources/trophy.desktop: warning: value
"Application;Game;ArcadeGame;" for key "Categories" in group "Desktop
Entry" contains a deprecated value "Application"
gcc warnings to forward/fix upstream:
caresources.cpp: In member function 'void CAResources::load()':
caresources.cpp:141:22: warning: ignoring return value of 'int
chdir(const char*)', declared with attribute warn_unused_result
[-Wunused-result]
player.cpp: In member function 'void Player::checkFunctionMap()':
player.cpp:462:18: warning: variable 'r' set but not used
[-Wunused-but-set-variable]
player.cpp:462:24: warning: variable 'a' set but not used
[-Wunused-but-set-variable]
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: