Re: RFS: Adopted Package: pathogen
Bas Wijnen wrote:
Hi Barry,
On Wed, Apr 16, 2008 at 05:06:17PM -0400, Barry deFreese wrote:
I went ahead and adopted pathogen and stuck it on mentors if anyone has
time to review and/or upload:
I'm looking at it now. Vim gives me reverse video (suggesting error) on
this:
Vcs-Svn: ssh://svn.debian.org/svn/pkg-games/packages/trunk/pathogen/
I think it does this because users cannot check this out, since they
don't have ssh access. It should instead be pointing to the public
repository. (This link is meant for users who want the latest
packaging, not for the package maintainers.)
Fixed
And of course I have something to complain about the copyright file
again. I hope you don't mind. ;-)
<snip>
Fixed, I think. Please review.
The menu and desktop files say Games/Strategy... That doesn't seem
appropriate...?
Aye, agreed. I've moved it to PuzzleGame for right now though I'm not
sure I'm happy with that either. Thoughts?
In debian/rules, the configure[-stamp] targets seem quite useless. I'm
very much in favour of regenerating configure, but this program uses a
simple Makefile, so there is no configure. I'd suggest you remove the
target and let build-stamp depend on patch directly.
Done.
You don't need debian/dirs, since the install target creates the
directories.
Gone.
Thanks,
Bas
No, thank you! :)
Ps: I didn't hear anything about xlife again; did I miss a message from
you? Except for making the copyright file as good as possible (without
a reply from the people in there), it's ready to upload AFAIK.
I sent one a little while back. I thought it was ready to go but maybe
it's time for a review? It's on mentors. I'm sure you will have
something to complain about the copyright file, such as it not being in
machine readable format.. ;-P
Thanks again!
Barry deFreese
Reply to: