[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#850181: plymouth theme(s) should provide fsck progress support

Package: desktop-base
Version: 9.0.0

Am 04.01.2017 um 17:42 schrieb Didier Roche:
> Le 04/01/2017 à 17:28, Aurélien COUDERC a écrit :
>> Le 4 janvier 2017 16:50:51 GMT+01:00, Didier Roche <didrocks@ubuntu.com>
>> a écrit :
>>>     Indeed, I ensure we do have all bits needed in plymouth, and then, only
>>>     the themes can hook up as they need and treat the prepending "fsckd:"
>>>     message in a special way (took a look at what we do in the text and
>>>     ubuntu-logo theme, it should be straightforward)
>>>     Didier
>> Oh right, feel free to open a different bug then I'll have another look.

I'm quoting the full message here to include Didier's excellent reply.

>> I've already diffed against xenial logo-theme while working on this and
>> didn't notice meaningful differences.
>> But I may have missed the relevant bits, or the systemd/fsckd
>> integration may have been implemented post-xenial in Ubuntu.
> For reference, I did try to be backward compatible (we did have this
> support some time ago for all flavors), but just added more messages
> type (I wouldn't say the ubuntu logo theme is the cleanest code-wise):
> If my memory is correct (I didn't do the first implementation with
> upstart years ago, just modified to work with systemd-fsckd), but
> basically, there are 2 channels of messages that you hook in in your theme:
> * an "update status" plymouth callback:
> systemd-fsckd pass fsckd:<number_devices>:<progress>:<l10n_string>
> * another is a "message" plymouth callback prefixed by
> "fsckd-cancel-msg:l10n_string" with the cancel message to display when
> available.
> The rest like handling Ctrl+C and such is done in plymouth side itself
> if my memory is correct (I don't remember if debian took it).
> Didier

Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: