[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#843998: plymouth theme missing for softwaves

Le 04/01/2017 à 17:28, Aurélien COUDERC a écrit :
> Le 4 janvier 2017 16:50:51 GMT+01:00, Didier Roche <didrocks@ubuntu.com>
> a écrit :
>     Le 04/01/2017 à 16:31, Michael Biebl a écrit :
>         Am 04.01.2017 um 15:41 schrieb Michael Biebl:
>             Am 04.01.2017 um 14:59 schrieb Aurélien COUDERC:
>                 For fsck/others I think the support is to be done…
>                 everywhere else !
>                 Basically we've taken inspiration (read blindly copied)
>                 what Ubuntu
>                 does, so Plymouth and the Debian theme support fsck
>                 display since wheezy.
>                 The missing part is that init/fsck/whoever else actually
>                 sends
>                 information to plymouthd to display.
>             I actually think this is not the case. systemd, or rather
>             fsckd *does*
>             send progress information (see the patch we ship in Debian
>             for systemd
>             [1]) for plymouth. But it seems this information is not used
>             on either
>             the plymouth or the theme side.
>         I just tried the following
>         a/ copied /usr/share/plymouth/themes/ubuntu-logo/ from a Ubuntu
>         yakkety
>         installation into my Debian sid system
>         b/ plymouth-set-default-theme ubuntu-logo
>         c/ update-initramfs -u
>         Upon reboot, I get the Ubuntu plymouth splash screen and progress
>         information seems to work nicely (I get the msg that fsck is
>         running for
>         1 Disk and the percentage done). I can successfully cancel the fsck
>         process with CTRL+C
>         So it looks like systemd and plymouth provide everything that's
>         needed
>         and it's a theme issue.
>     Indeed, I ensure we do have all bits needed in plymouth, and then, only
>     the themes can hook up as they need and treat the prepending "fsckd:"
>     message in a special way (took a look at what we do in the text and
>     ubuntu-logo theme, it should be straightforward)
>     Didier
> Oh right, feel free to open a different bug then I'll have another look.
> I've already diffed against xenial logo-theme while working on this and
> didn't notice meaningful differences.
> But I may have missed the relevant bits, or the systemd/fsckd
> integration may have been implemented post-xenial in Ubuntu.

For reference, I did try to be backward compatible (we did have this
support some time ago for all flavors), but just added more messages
type (I wouldn't say the ubuntu logo theme is the cleanest code-wise):

If my memory is correct (I didn't do the first implementation with
upstart years ago, just modified to work with systemd-fsckd), but
basically, there are 2 channels of messages that you hook in in your theme:

* an "update status" plymouth callback:
systemd-fsckd pass fsckd:<number_devices>:<progress>:<l10n_string>

* another is a "message" plymouth callback prefixed by
"fsckd-cancel-msg:l10n_string" with the cancel message to display when

The rest like handling Ctrl+C and such is done in plymouth side itself
if my memory is correct (I don't remember if debian took it).


Reply to: