[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Logging multiple builds



On 12 July 2014 19:49, Anders Ingemann <anders@ingemann.de> wrote:
On 12 July 2014 19:45, Tomasz Rybak <tomasz.rybak@post.pl> wrote:
Dnia 2014-07-12, sob o godzinie 12:13 +0200, Tomasz Rybak pisze:
[ cut ]
> Thanks - it is very nice change.
> It allowed for small simplification of my code.
> I'll test it a bit and shall let you know how it works.
>

I've updated my code to use the latest commit from development
branch. I had two problems:
1. I did not use "credential" key in "provider" which caused
crash when checking for AWS key/secret - see PR #120.
2. Because "virtualization" got moved into "provider",
some manifests crashed:
 INFO: Determining the AMI name
[14306.317091] ERROR: 'virtualization'
Traceback (most recent call last):
  File "/home/admin/bootstrapvz/base/main.py", line 96, in run
    tasklist.run(info=bootstrap_info, dry_run=dry_run)
  File "/home/admin/bootstrapvz/base/tasklist.py", line 38, in run
    task.run(info)
  File "/home/admin/bootstrapvz/providers/ec2/tasks/ami.py", line 21, in
run
    ami_name = info.manifest.image['name'].format(**info.manifest_vars)
KeyError: 'virtualization'

Changing
name: debian-{system.release}-{system.architecture}-{virtualization}-{%
Y}-{%m}-{%d}-ebs
to
name:
debian-{system.release}-{system.architecture}-{provider.virtualization}-{%Y}-{%m}-{%d}-ebs

helped. Should I fix all manifests in repository and create pull
request?

Best regards.

--
Tomasz Rybak  GPG/PGP key ID: 2AD5 9860
Fingerprint A481 824E 7DD3 9C0E C40A  488E C654 FB33 2AD5 9860
http://member.acm.org/~tomaszrybak


> 1. I did not use "credential" key in "provider" which caused crash when checking for AWS key/secret - see PR #120.
Already merged :-)
> 2. Because "virtualization" got moved into "provider", some manifests crashed:
> Should I fix all manifests in repository and create pull request?
Aw snap, I'm sorry about that, you shouldn't have to fix that. I screwed up and I should fix it :-)
I'll push something tonight or tomorrow.

Woops, didn't answer to the list before. See my answer above.

2. is now fixed, I also pushed some changes that fix the failing travis-ci build.

Reply to: