On 2014-07-30 15:57:08, Olivier Berger wrote: > Hi. Hello, > I've had a look at the package, and I'd like to suggest the following > change. Thx for this. > Since the VirtualBox guest additions is packaged in Debian, I would > suggest to add it as a suggested package, and to adjust the path of the > iso file : > > virtualbox-vagrant.manifest.yml would then contain : > ... > provider: > name: virtualbox > guest_additions: /usr/share/virtualbox/VBoxGuestAdditions.iso > ... Seams to be reasonable. Only small issue is that on master branch there are still json files when dev have been converted to yaml. So it should be more like this on master: /manifests/virtualbox-vagrant.manifest.json - "guest_additions": "/root/images/VBoxGuestAdditions.iso" + "guest_additions": "/usr/share/virtualbox/VBoxGuestAdditions.iso" /manifests/virtualbox.manifest.json - // "guest_additions": "/root/images/VBoxGuestAdditions.iso" + "guest_additions": "/usr/share/virtualbox/VBoxGuestAdditions.iso" I'll add virtualbox-guest-additions-iso as a suggest to the next build. > Btw, this leads me to a question : how do you intend to manage potential > patches vs upstream sources ? Patches against upstream are not problem from what I can tell. Anders is very capable and easy to talk to so I'm sure we'll be ok on this front. > Are you using any sort of Git package building tool ? If so, may I > suggest to document that somewhere in the debian/READMEs... I assume you grabbed package from mentors, correct? Below entry from d/control should answer your question: Vcs-Git: git://anonscm.debian.org/cloud/bootstrap-vz.git Regarding suggestion to document this, well I could do it as I did it in my other package but I'm not sure if it will bring any additional value. Let me think about it. > Hope this helps. Thx a lot for voicing your opinion, all what helps to make this package better is highly appreciated. BTW no need for cc'ing me in I'm subscribed to the 'cloud list' -- |_|0|_| | |_|_|0| "Heghlu'Meh QaQ jajVam" | |0|0|0| -------- kuLa --------- | gpg --keyserver pgp.mit.edu --recv-keys 0x58C338B3 3DF1 A4DF C732 4688 38BC F121 6869 30DD 58C3 38B3
Attachment:
signature.asc
Description: Digital signature