Re: Review of package tools-deps-alpha

[Leandro Doctors <ldoctors@gmail.com>]

On Mon, 16 Aug 2021 at 02:08, Louis-Philippe Véronneau <pollo@debian.org> wrote:
>
> Hi,
>
> This is my review of tools-deps-alpha. I'm proceeding via email, as it
> makes for a clearer list of things to fix.

Thanks a lot for your detailed review!
I reply to some of your comments below.


> 4. In d/libtools-deps-alpha-clojure.classpath, you are loading jars from
> /usr/share/java/ and from /usr/share/maven-repo/. They should all be
> from /usr/share/java/.

You're mostly right here. Just one caveat: in the case of
`libspec-alpha-clojure`,
that package does not provide any `.jar` in `/usr/share/java`
(Probably a bug in `libspec-alpha-clojure`?)
I'll check this with the rest of the packages, though.


> 6. In d/libtools-deps-alpha-clojure.classpath, you aren't loading any
> jars from libspec-alpha-clojure, although it's a build-dep and I see
> that src/main/clojure/clojure/tools/deps/alpha/specs.clj requires it.
> Your testsuite passes though, so maybe I'm wrong?

Chances are, you missed that I do load it, but from
/usr/share/maven-repo (see above).


> Otherwise your package is Lintian clean and all tests pass. Good job!

Thanks!

I'll address the rest of your comments and let you know.

Best,
Leandro