Re: Cinnamon 4.2, salsa and master branch
Il 25/09/2019 07:54, Norbert Preining ha scritto:
> Hi Fabio,
>
> On Tue, 24 Sep 2019, Fabio Fantoni wrote:
>> There is the option to fallback to cinnamon without 3d parts
>> applet/extension on the wrapper other that only restart with other panels.
>>
>> Should be simple but I not have enough knowledge (or memory) of gtk,
>> python and c for do it fast.
> I looked into it and didn't see an easy way to convey this information
> from the launcher back to the cinnamon process and in particular the cjs
> system that is started via the muffin plugin system.
>
> I made a patch that takes a different approach: If the call to
> main.js::start() fails, then retry with main.js::start(false)
> (this is in src/cinnamon-plugin.c).
> The optional argument to start() is passed on to the initialization of
> the various managers (applet, etension, search,...) and from there down
> all the way to the loading of the extension.
>
> I send a link to the patch with descriptions to the IRC channel, and
> attach the patch here.
>
> If any of you have comments, please let me know.
Thanks for your work, probably is better for me avoid to give you wrong
advice based on too fast look, I suggest to add it as "[WIP]" PR
upstream (https://github com/linuxmint/cinnamon/pulls) for comments and
possible help of upstream developers.
The only thing I think is that do autofallback as it is this patch you
did without let user to know what happen seems not good to use (except
testing) and doing it starting from wrapper with gtk gui part as
suggested by clem is needed.
>
>> in files/usr/share/cinnamon/cinnamon-settings/modules/cs_desklets.py:
>> in files/usr/share/cinnamon/cinnamon-settings/modules/cs_extensions.py:
> ..
>
> I don't think that changing something there will change anything,
> because it will only change something in the cinnamon setttings app, but
> not in the initial loading of applets.
>
>
> Do we want to wait for cinnamon upstream to provide something, or do we
> upload to unstable? I don't see that waiting does make any sense. We
> don't get testing in unstable, and the situation hasn't changed since
> old versions of cinnamon, so there is no regression.
>
> Well, anyway, enjoy, and let me know what you think!
>
> Thanks
>
> Norbert
>
> --
> PREINING Norbert http://www.preining.info
> Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
> GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
Reply to: