[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#895445: marked as done (Drop (unused) Build-Depends on network-manager-dev)

Your message dated Thu, 12 Apr 2018 11:04:27 +0000
with message-id <E1f6a1j-000Ixz-P4@fasolo.debian.org>
and subject line Bug#895445: fixed in cinnamon-control-center 3.6.5-2
has caused the Debian Bug report #895445,
regarding Drop (unused) Build-Depends on network-manager-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
895445: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895445
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cinnamon-control-center
Version: 3.6.5-1.1
Severity: wishlist
Tags: patch
User: pkg-utopia-maintainers@lists.alioth.debian.org
Usertags: libnm


Hi,

cinnamon-control-center declares a Build-Depends on network-manager-dev.

Afaics, the only reason why NetworkManager.pc is required is due to the
following in configure.ac:

      NM_VPN_CONFIG_DIR=`$PKG_CONFIG --variable configdir NetworkManager`/VPN
      NM_VPN_MODULE_DIR=`$PKG_CONFIG --variable plugindir NetworkManager`
      AC_SUBST(NM_VPN_CONFIG_DIR)
      AC_SUBST(NM_VPN_MODULE_DIR)

Those defines, NM_VPN_CONFIG_DIR and NM_VPN_MODULE_DIR are never used in
the code though. It thus seems safe to drop the Build-Depends on
network-manager-dev and clean up the use of
NM_VPN_CONFIG_DIR/NM_VPN_MODULE_DIR (patch for that is attached).
Please consider applying the attached patch in your next upload and drop
the Build-Depends on network-manager-dev.

Thanks,
Michael

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Description: Stop requiring NetworkManager.pc
 We don't actually use NM_VPN_CONFIG_DIR and NM_VPN_MODULE_DIR, along with the
 corresponding configure check.
Author: Michael Biebl <biebl@debian.org>

--- cinnamon-control-center-3.6.5.orig/configure.ac
+++ cinnamon-control-center-3.6.5/configure.ac
@@ -157,10 +157,6 @@ if test "x$enable_networkmanager" = xyes
 
     if test x${have_networkmanager} = xyes; then
       AC_DEFINE(HAVE_NETWORK_MANAGER, 1, [Define to 1 if NetworkManager is available])
-      NM_VPN_CONFIG_DIR=`$PKG_CONFIG --variable configdir NetworkManager`/VPN
-      NM_VPN_MODULE_DIR=`$PKG_CONFIG --variable plugindir NetworkManager`
-      AC_SUBST(NM_VPN_CONFIG_DIR)
-      AC_SUBST(NM_VPN_MODULE_DIR)
     fi
 
     if test x${have_nma_18} = xyes; then
--- cinnamon-control-center-3.6.5.orig/panels/network/connection-editor/Makefile.am
+++ cinnamon-control-center-3.6.5/panels/network/connection-editor/Makefile.am
@@ -37,9 +37,7 @@ libconnection_editor_la_CPPFLAGS = 		\
 	$(PANEL_CFLAGS)				\
 	-I$(srcdir)/../wireless-security	\
 	$(NETWORK_PANEL_CFLAGS) 		\
-        $(NETWORK_MANAGER_CFLAGS)		\
-	-DNM_VPN_CONFIG_DIR=\""$(NM_VPN_CONFIG_DIR)"\" \
-	-DNM_VPN_MODULE_DIR=\""$(NM_VPN_MODULE_DIR)"\"
+        $(NETWORK_MANAGER_CFLAGS)
 
 libconnection_editor_la_LIBADD = 		\
 	$(builddir)/../wireless-security/libwireless-security.la \

--- End Message ---
--- Begin Message --- 
Source: cinnamon-control-center
Source-Version: 3.6.5-2

We believe that the bug you reported is fixed in the latest version of
cinnamon-control-center, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 895445@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Maximiliano Curia <maxy@debian.org> (supplier of updated cinnamon-control-center package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 12 Apr 2018 12:50:26 +0200
Source: cinnamon-control-center
Binary: cinnamon-control-center cinnamon-control-center-data libcinnamon-control-center-dev libcinnamon-control-center1
Architecture: source
Version: 3.6.5-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Cinnamon Team <debian-cinnamon@lists.debian.org>
Changed-By: Maximiliano Curia <maxy@debian.org>
Description:
 cinnamon-control-center - configuration applets for the Cinnamon desktop
 cinnamon-control-center-data - configuration applets for Cinnamon - data files
 libcinnamon-control-center-dev - configuration applets for Cinnamon - development files
 libcinnamon-control-center1 - library used by configuration applets for Cinnamon
Closes: 895445
Changes:
 cinnamon-control-center (3.6.5-2) unstable; urgency=medium
 .
   * New revision
   * Drop dh-autoreconf (no longer needed with dh >= 10)
   * Drop dh's parallel arg (no longer needed with dh >= 10)
   * Add patches for network-manager:
      * Stop-requiring-NetworkManager.pc (Closes: 895445)
      * Drop-unused-HAVE_NETWORK_MANAGER
   * Drop network-manager-dev build dep
   * Release to unstable
Checksums-Sha1:
 de77628b5cc3fced47a0e6e1f37658564b649a33 3261 cinnamon-control-center_3.6.5-2.dsc
 80222fa35ce8e2b11acf7499ad94e671d54b02e9 8800 cinnamon-control-center_3.6.5-2.debian.tar.xz
 86aee83c1cd14cdac4c43b27c7834dc65521dc93 16759 cinnamon-control-center_3.6.5-2_source.buildinfo
Checksums-Sha256:
 d7a3f6cf01b5e8b8456fb00f486fbbe79e500531c4dbf89c98bcd19c438b51ef 3261 cinnamon-control-center_3.6.5-2.dsc
 9d819711e510cad04fbe6855aa883f6ba0af2d61541ffefe5ddce8c92ae82b1e 8800 cinnamon-control-center_3.6.5-2.debian.tar.xz
 2ffa5bb98bf246a98e97a46603c6ecc86c96d8487d05ccd0c5bdcf3f0a6b1173 16759 cinnamon-control-center_3.6.5-2_source.buildinfo
Files:
 dbf7dc6e5fe1563406c19279e36c264e 3261 x11 optional cinnamon-control-center_3.6.5-2.dsc
 187dede7b028052507677139a4b0a4a6 8800 x11 optional cinnamon-control-center_3.6.5-2.debian.tar.xz
 3f898f275b26795b4370e19418ebf935 16759 x11 optional cinnamon-control-center_3.6.5-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+JIdOnQEyG4RNSIVxxl2mbKbIyoFAlrPOf8ACgkQxxl2mbKb
IypaMBAAstFaUjbzmpkpa+7VOp6CphA5kLw/bq033R0NZOdwOrRPVvcyeNvUhu+K
SHHHIpUVsx/vL7tIR9w+D/7R/XUHa+0bmkiaX73GnFVfr9FVyw68SyDgLHYGsUeJ
Sc//0SPzI7xoP7DnR7wFfRSO+dFeWoHbsnOLzPFgWOlQPFa+7kenFiLgwahYgCNw
WivuS9qi3nDUw7LEb1DYXa2UythxSfOqAWV+J4VhcIp4PjI3PWoucJMSe4iXgRs1
Nol5gOkP0Ct4fjk9VXmtfczDay4tu4xhf/MkIKJc4ovJkEU83j80SxkKQGPPIvLL
4/O4ZtkPWeeiHW3mdE6QzOMN+sT1gTq7+Vrc/7znwE7Uz+yIE6dP4MawsxfkraPj
CwzixdTImAX1ByEAuxwX8Q/N5FQIz83DfqR+wteTZ9Rj9I4A/WsgTNHrDsmI8vd8
qFIEPFuXT215zqXOykFgs+zlo2bqL+Y39K+bsRaErU9ofQR4hRZ1QWhgJv3Kz8M3
L49JrFxmCXZ8Olj+u1hK0AcL1fW9S28XHAjZ7v/tAZzoa60u3O2nBIyIKCj1PK6w
npFC3TwF3Rl/m4oZrHamVpkPjG7XJjRkYvOL8G6U9Yg8ydmhkVzbFeHzkgVWfe/s
yPx7wdrxdDSGm5mke6YYQx8yeL60EwF1GnkWckTnIe4t3BD+qrU=
=nuZt
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: