Re: Rxvt question
On Wed, Jun 30, 1999 at 10:07:32AM -0400, Brrian Mays wrote:
|
|I have three comments for now:
|
|(1) There is really no reason to have the line
|
|#DEFAULT_RXVT=$RXVT_GB
|
|in the script. Since this script is not a conffile (at least I don't
|think that it should be), it should not be edited by the system
|adminstrator.
Well...Up to the package maintainer to make the final decision :))
|
|(2) I think that the rxvt binaries should be "exec"ed. There is no need
|for an extra shell process to be floating around for each invocation of
|crxvt.
Yes, exec should be used. Now you know how bad my shell programming is :P
|(3) We both forgot to include the extra command line options provided by
|the user. I'll add the appropriate "$*"'s to the script.
Sure. I'm too careless...
|On that note, are you sure that we want to automatically add "-im xcin -pt
|Root" to the command line options? I think that this might be confusing,
|since "crxvt" would behave differently from "crxvt-big5" and "crxvt-gb".
|That is, both crxvt-big5 and crxvt-gb will require the user to add these
|options to work correctly, whereas crxvt will not require these options.
|What do you think?
Right, confusion is a very bad thing. I think we should leave out the
"-im xcin -pt Root" arguments from the shell scripts.
--
Anthony Wong. [ E-mail: hajime@asunaro.dhs.org / ypwong@debian.org ]
Reply to: