Ian Campbell: > On Thu, 2016-01-28 at 16:36 +0000, Ian Campbell wrote: > > > > While, I am at it, I wonder if it would not make more sense to > > > > reverse the order when setting that variable so it reads: > > > > > > > > setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}" > > > > > > > > That way, it's possible to override the default command line by doing > > > > something like: > > > > > > > > setenv bootargs console=ttyAMA0,115200 > > > > boot > > > > > > Yes, I guess that makes sense. Ian, do you see anything that would speak > > > against this change? > > > > It would prevent @@LINUX_KERNEL_CMDLINE@@ from overriding a bad (or just > > inconvenient) ${bootargs} baked into a system's default firmware? In some > > cases things are headless so you can't fix ${bootargs} yourself. > > > > Perhaps we should switch things as suggested but also add > > @@LINUX_KERNEL_CMDLINE_OVERRIDES@@ at the end to allow us to put things at > > both the beginning and the end? > > Having slept on it I think we might be safer leaving the semantics of > @@LINUX_KERNEL_CMDLINE@@ alone, but we could always add a different > substitution at the beginning of the line (e.g. > @@LINUX_KERNEL_CMDLINE_DEFAULTS@@ perhaps). Another option to fit my use case is to change the default script to add an extra variable: setenv bootargs "${bootargs} @@LINUX_KERNEL_CMDLINE@@ ${extra_bootargs}" Then I could do: setenv extra_bootargs "ip=dhcp" boot -- Lunar .''`. lunar@debian.org : :Ⓐ : # apt-get install anarchism `. `'` `-
Attachment:
signature.asc
Description: Digital signature