Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

[Karsten Merker <merker@debian.org>]

On Thu, Jan 28, 2016 at 04:19:27PM +0100, Jérémy Bobbio wrote:
> Package: flash-kernel
> Version: 3.56
> Tag: patch
> 
> Hi!
> 
> There's a small quoting mistake in the generic U-Boot script. It
> probably hasn't been noticed so far because the default
> LINUX_KERNEL_CMDLINE doesn't contain spaces. See the attached patch.
[...]
> -setenv bootargs ${bootargs} @@LINUX_KERNEL_CMDLINE@@
> +setenv bootargs "${bootargs} @@LINUX_KERNEL_CMDLINE@@"

Hello,

having no quotes should not be a problem for the u-boot setenv command:

=> setenv foo a b c d e
=> printenv foo
foo=a b c d e
=> setenv foo ${foo} bar baz
=> printenv foo
foo=a b c d e bar baz
=>

> While, I am at it, I wonder if it would not make more sense to
> reverse the order when setting that variable so it reads:
> 
>     setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}"
> 
> That way, it's possible to override the default command line by doing
> something like:
> 
>     setenv bootargs console=ttyAMA0,115200
>     boot

Yes, I guess that makes sense. Ian, do you see anything that would speak
against this change?

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.