Package: flash-kernel
Version: 3.56
Tag: patch
Hi!
There's a small quoting mistake in the generic U-Boot script. It
probably hasn't been noticed so far because the default
LINUX_KERNEL_CMDLINE doesn't contain spaces. See the attached patch.
While, I am at it, I wonder if it would not make more sense to
reverse the order when setting that variable so it reads:
setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}"
That way, it's possible to override the default command line by doing
something like:
setenv bootargs console=ttyAMA0,115200
boot
--
Lunar .''`.
lunar@debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
From 8d87ea9e4adcc48e4bffa0ff3a378fc3e417afe4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Bobbio?= <lunar@debian.org>
Date: Thu, 28 Jan 2016 16:14:28 +0100
Subject: [PATCH] Properly quote LINUX_KERNEL_CMDLINE in U-Boot generic boot
script
Otherwise we get an error as soon as LINUX_KERNEL_CMDLINE contains spaces.
---
bootscript/all/bootscr.uboot-generic | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bootscript/all/bootscr.uboot-generic b/bootscript/all/bootscr.uboot-generic
index c318be5..1c3f129 100644
--- a/bootscript/all/bootscr.uboot-generic
+++ b/bootscript/all/bootscr.uboot-generic
@@ -25,7 +25,7 @@ if test -n "${console}"; then
setenv bootargs "${bootargs} console=${console}"
fi
-setenv bootargs ${bootargs} @@LINUX_KERNEL_CMDLINE@@
+setenv bootargs "${bootargs} @@LINUX_KERNEL_CMDLINE@@"
@@UBOOT_ENV_EXTRA@@
if test -z "${fk_kvers}"; then
--
2.1.4
Attachment:
signature.asc
Description: Digital signature